Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "when" method for validation at condition #55

Merged
merged 25 commits into from Mar 3, 2020

Conversation

@thenotsoft
Copy link
Contributor

thenotsoft commented Feb 27, 2020

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Feb 28, 2020

@thenotsoft would you please resolve conflicts?

@samdark samdark requested a review from yiisoft/reviewers Mar 1, 2020
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Mar 2, 2020

@thenotsoft seems to fail tests.

src/Rule.php Outdated Show resolved Hide resolved
thenotsoft and others added 2 commits Mar 2, 2020
Co-Authored-By: Dmitriy Derepko <xepozz@list.ru>
@samdark samdark requested a review from yiisoft/reviewers Mar 3, 2020
src/Rule.php Show resolved Hide resolved
tests/ValidatorTest.php Outdated Show resolved Hide resolved
samdark added 2 commits Mar 3, 2020
samdark added 2 commits Mar 3, 2020
@samdark
samdark approved these changes Mar 3, 2020
@samdark samdark merged commit e3b311a into yiisoft:master Mar 3, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/styleci/pr Issues have been identified with 1 file
Details
Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
Travis CI - Pull Request Build Passed
Details
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Mar 3, 2020

Adjusted it and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.