Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements, fix #98, #129 #134

Merged
merged 8 commits into from
Apr 15, 2022
Merged

Enhancements, fix #98, #129 #134

merged 8 commits into from
Apr 15, 2022

Conversation

rustamwin
Copy link
Member

@rustamwin rustamwin commented Apr 10, 2022

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues #98, #129, #123

src/Data/Reader/EntityReader.php Outdated Show resolved Hide resolved
src/Data/Reader/EntityReader.php Outdated Show resolved Hide resolved
src/Command/Migration/DownCommand.php Outdated Show resolved Hide resolved
@rustamwin rustamwin requested a review from a team April 10, 2022 15:53
@rustamwin rustamwin added the status:code review The pull request needs review. label Apr 10, 2022
src/Data/Reader/EntityReader.php Outdated Show resolved Hide resolved
src/Data/Reader/EntityReader.php Outdated Show resolved Hide resolved
src/Data/Reader/EntityReader.php Outdated Show resolved Hide resolved
@rustamwin rustamwin requested a review from a team April 13, 2022 13:32
@roxblnfk
Copy link
Member

Looks ok

@samdark
Copy link
Member

samdark commented Apr 15, 2022

@rustamwin is it possible to fix CI?

@roxblnfk
Copy link
Member

@rustamwin is it possible to fix CI?

Not in this PR

@samdark samdark merged commit 66e2b2b into 2.0 Apr 15, 2022
@samdark samdark deleted the enh branch April 15, 2022 20:49
@samdark
Copy link
Member

samdark commented Apr 15, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants