Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring #30

Merged
merged 7 commits into from Nov 12, 2019
Merged

Some refactoring #30

merged 7 commits into from Nov 12, 2019

Conversation

@xepozz
Copy link
Contributor

xepozz commented Nov 7, 2019

Q A
Is bugfix? ✔️/
New feature?
Breaks BC?
Tests pass? ✔️/
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Nov 11, 2019

@xepozz is it still work in progress or could be reviewed?

@xepozz

This comment has been minimized.

Copy link
Contributor Author

xepozz commented Nov 11, 2019

Maybe later I will continue it.
Now you can review it and merge if it's ok.

@samdark samdark merged commit 7171578 into yiisoft:master Nov 12, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
continuous-integration/styleci/pr The analysis has passed
Details
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Nov 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.