Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring #30

Merged
merged 7 commits into from Nov 12, 2019
Merged

Some refactoring #30

merged 7 commits into from Nov 12, 2019

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Nov 7, 2019

Q A
Is bugfix? ✔️/
New feature?
Breaks BC?
Tests pass? ✔️/

@samdark
Copy link
Member

@samdark samdark commented Nov 11, 2019

@xepozz is it still work in progress or could be reviewed?

@xepozz
Copy link
Contributor Author

@xepozz xepozz commented Nov 11, 2019

Maybe later I will continue it.
Now you can review it and merge if it's ok.

@samdark samdark added the status:code review label Nov 12, 2019
@samdark samdark merged commit 7171578 into yiisoft:master Nov 12, 2019
1 of 2 checks passed
@samdark
Copy link
Member

@samdark samdark commented Nov 12, 2019

Thanks!

@samdark samdark removed the status:code review label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants