Base for a blog example #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # resources/mail/layouts/html.php
# Conflicts: # composer.json # config/console.php # src/Entity/User.php # src/Factory/AppRouterFactory.php # src/globals.php
# Conflicts: # composer.json # config/common.php # src/Entity/User.php # src/Factory/AppRouterFactory.php # src/Repository/UserRepository.php # src/globals.php
# Conflicts: # config/params.php # src/Command/User/CreateCommand.php
|
Classes should be grouped either by a type or by a layer. |
xepozz
requested changes
Feb 9, 2020
xepozz
reviewed
Feb 10, 2020
samdark
requested changes
Feb 14, 2020
| @@ -19,6 +19,7 @@ | |||
| "require": { | |||
| "php": "^7.4", | |||
| "cebe/markdown": "^1.2@dev", | |||
| "cycle/proxy-factory": "^1.2", | |||
There was a problem hiding this comment.
Should it be required directly? Do we need it all the time? If so, does it make sense to move it to yii-cycle?
samdark
reviewed
Feb 14, 2020
|
Don't forget to make your controllers compatible. (#54 already in |
|
@xepozz isn't it already done? |
|
Oh, sorry. It's already complete :) |
…d of ORMInterface
Fixed in yiisoft/yii-cycle#23 and last commit |
samdark
approved these changes
Feb 16, 2020
|
Merged! Awesome job overall 👍 Let's continue with further fixes / enhancements separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick start
config/params.php(you can skip this step)composer installvendor/bin/yii serveor start your web-serverOn this step the Cycle ORM will create tables, indexes and relations automatically in the configured DB.
If you want to disable this behavior then comment out line with
Generator\SyncTables::classin theconfig/params.phpfile. In this case you should create migrations to sync changes of entities with DBvendor/bin/yii fixture/add 20to create random dataFeatures:
yii serve)Todo:
OffsetPaginatorfromyiisoft/datapackageyiisoft/widgetintegration