Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter and streamed output #165

Closed
roxblnfk opened this issue Nov 22, 2019 · 5 comments
Closed

Emitter and streamed output #165

roxblnfk opened this issue Nov 22, 2019 · 5 comments
Assignees

Comments

@roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Nov 22, 2019

We have a situation where the content of the stream are first completely unloaded into memory, and only then sent to the user.

The Emitter should output the stream in parts.

We should also consider supporting HTTP Range Requests.

@kamarton

This comment has been minimized.

Copy link
Contributor

@kamarton kamarton commented Nov 24, 2019

It should also be possible to disable this feature, as it is mostly not needed.

@roxblnfk

This comment has been minimized.

Copy link
Member Author

@roxblnfk roxblnfk commented Nov 24, 2019

I think that to send ranged Responses needed an individual Emitter, because for it to work correctly, we need to pass a Request object to it. And this is a different signature.

@samdark

This comment has been minimized.

Copy link
Member

@samdark samdark commented Nov 24, 2019

Interface could be adjusted if needed.

@roxblnfk roxblnfk self-assigned this Nov 24, 2019
@kamarton

This comment has been minimized.

Copy link
Contributor

@kamarton kamarton commented Nov 24, 2019

I suggest middleware instead of modifying the Emitter interface.

@roxblnfk

This comment has been minimized.

Copy link
Member Author

@roxblnfk roxblnfk commented Nov 24, 2019

I suggest middleware instead of modifying the Emitter interface.

@samdark and i also came to this conclusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.