Skip to content
This repository has been archived by the owner. It is now read-only.

Callback middleware unit tests #113

Merged
merged 5 commits into from Sep 10, 2019
Merged

Callback middleware unit tests #113

merged 5 commits into from Sep 10, 2019

Conversation

@romkatsu
Copy link
Member

@romkatsu romkatsu commented Sep 8, 2019

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #105
Copy link
Member

@samdark samdark left a comment

Thanks for contribution. Some important cases are missing:

  • Check that request is passed to callback.
  • Check that when using type-hints in a callback, DI container get() is called i.e. autowiring works.

tests/Middleware/CallbackTest.php Outdated Show resolved Hide resolved
tests/Middleware/CallbackTest.php Outdated Show resolved Hide resolved
@romkatsu romkatsu requested a review from samdark Sep 9, 2019
@samdark samdark merged commit 7a685f9 into yiisoft:master Sep 10, 2019
3 checks passed
@samdark
Copy link
Member

@samdark samdark commented Sep 10, 2019

Merged. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants