Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback middleware unit tests #113

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@romkatsu
Copy link
Contributor

commented Sep 8, 2019

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #105
romkatsu added 2 commits Sep 8, 2019
Copy link
Member

left a comment

Thanks for contribution. Some important cases are missing:

  • Check that request is passed to callback.
  • Check that when using type-hints in a callback, DI container get() is called i.e. autowiring works.
tests/Middleware/CallbackTest.php Outdated Show resolved Hide resolved
tests/Middleware/CallbackTest.php Outdated Show resolved Hide resolved
romkatsu added 3 commits Sep 9, 2019
romkatsu
romkatsu
@romkatsu romkatsu requested a review from samdark Sep 9, 2019
@samdark samdark merged commit 7a685f9 into yiisoft:master Sep 10, 2019
3 checks passed
3 checks passed
Scrutinizer 16 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdark

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.