Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement authentication middleware #116

Merged
merged 15 commits into from Oct 2, 2019

Conversation

@rustamwin
Copy link
Contributor

commented Sep 19, 2019

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? -
Fixed issues #114
@samdark samdark requested review from samdark, yiisoft/reviewers and FabrizioCaldarelli Sep 19, 2019
src/Auth/AuthInterface.php Outdated Show resolved Hide resolved
src/Auth/AuthMiddleware.php Outdated Show resolved Hide resolved
src/Auth/AuthMiddleware.php Outdated Show resolved Hide resolved
src/Auth/HttpBasicAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpBasicAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpHeaderAuthTrait.php Outdated Show resolved Hide resolved
@rustamwin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

We need method CompositeAuth as well?

@samdark

This comment has been minimized.

Copy link
Member

commented Sep 28, 2019

Yes. A way to configure multiple auth methods is needed.

@rustamwin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

@samdark Done.

Copy link
Member

left a comment

Almost there 👍

src/Auth/AuthMiddleware.php Outdated Show resolved Hide resolved
src/Auth/CompositeAuth.php Outdated Show resolved Hide resolved
src/Auth/CompositeAuth.php Outdated Show resolved Hide resolved
src/Auth/CompositeAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpBasicAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpBasicAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpBasicAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpBearerAuth.php Outdated Show resolved Hide resolved
src/Auth/HttpHeaderAuth.php Outdated Show resolved Hide resolved
src/Auth/QueryParamAuth.php Outdated Show resolved Hide resolved
fix
@samdark
samdark approved these changes Oct 2, 2019
@samdark

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

@rustamwin looks good to me now. Do you want to work on unit tests for it?

@rustamwin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

@samdark Not sure if there will be time to work with unit tests :(

@samdark samdark merged commit 3c79d60 into yiisoft:master Oct 2, 2019
3 checks passed
3 checks passed
Scrutinizer 33 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdark

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

OK. Merging then. Thank you very much.

@rustamwin rustamwin deleted the rustamwin:auth branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.