Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ErrorCatcher with default content type #159

Merged

Conversation

@kamarton
Copy link
Contributor

kamarton commented Nov 20, 2019

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues #155

The #158 issue has a problem with the tests, which ruins a number of other tests. The ErrorHandler registers to error handler and causes problems in other tests. I don't know if this could cause a problem in the future.

samdark added 4 commits Nov 20, 2019
@samdark samdark merged commit 5547702 into yiisoft:master Nov 20, 2019
3 checks passed
3 checks passed
Scrutinizer 1 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdark

This comment has been minimized.

Copy link
Member

samdark commented Nov 20, 2019

Fixed tests, formatting and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.