Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #93: Add non-verbose mode for ErrorHandler #168

Merged
merged 11 commits into from Nov 28, 2019

Conversation

@samdark
Copy link
Member

samdark commented Nov 25, 2019

That would allow configuring it like the following:

Yiisoft\Yii\Web\ErrorHandler\ErrorHandler::class => function (ContainerInterface $container) {
    $errorHandler = $container->get(ErrorHandler::class);
    return $errorHandler->withoutExposedDetails();
},
Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #93
@samdark samdark requested a review from yiisoft/reviewers Nov 25, 2019
@schmunk42

This comment has been minimized.

Copy link
Contributor

schmunk42 commented Nov 26, 2019

Would be nice to have a use-case in the docs.

samdark added 4 commits Nov 26, 2019
@samdark

This comment has been minimized.

Copy link
Member Author

samdark commented Nov 26, 2019

@schmunk42 docs on error handler are to be done. Going to work on it soon.

samdark added 3 commits Nov 26, 2019
@samdark samdark marked this pull request as ready for review Nov 27, 2019
@samdark samdark requested a review from yiisoft/reviewers Nov 27, 2019
@samdark samdark mentioned this pull request Nov 27, 2019
@samdark samdark merged commit 9d1bd2f into master Nov 28, 2019
5 checks passed
5 checks passed
Scrutinizer Analysis: 21 updated code elements – Tests: passed
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@samdark samdark deleted the 93-add-non-verbose-mode-for-error-handler branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.