Update framework/db/ar/CActiveRecord.php

method save() always returns true, even if the record does not exist in the database
yiisoft · Jan 31, 2013 · 826be39 · 826be39
1 parent 8afb3b5
commit 826be39
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/framework/db/ar/CActiveRecord.php b/framework/db/ar/CActiveRecord.php
@@ -1068,7 +1068,9 @@ public function update($attributes=null)
 			Yii::trace(get_class($this).'.update()','system.db.ar.CActiveRecord');
 			if($this->_pk===null)
 				$this->_pk=$this->getPrimaryKey();
-			$this->updateByPk($this->getOldPrimaryKey(),$this->getAttributes($attributes));
+			if (!$this->updateByPk($this->getOldPrimaryKey(),$this->getAttributes($attributes))) {
+				return false;
+			}
 			$this->_pk=$this->getPrimaryKey();
 			$this->afterSave();
 			return true;