New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGridView::updateSelector bug #1080

Closed
alxkolm opened this Issue Jul 31, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@alxkolm

alxkolm commented Jul 31, 2012

Tokens {page} and {sort} in CGridView::updateSelector not replaced with proper selectors.
They insert directly:

jQuery('#itemGrid').yiiGridView({'ajaxUpdate':['itemGrid'],'ajaxVar':'ajax','pagerClass':'pager','loadingClass':'grid-view-loading','filterClass':'filters','tableClass':'items','selectableRows':1,'enableHistory':false,'updateSelector':'{page}, {sort}','pageVar':'page'});
});

jQuery throw exception:

Uncaught Error: Syntax error, unrecognized expression: {page}
@mdomba

This comment has been minimized.

Show comment
Hide comment
@mdomba

mdomba Jul 31, 2012

Member

This replacement happens on the client not on the server, so the above call is correct... did you clean the assets folder ?

Member

mdomba commented Jul 31, 2012

This replacement happens on the client not on the server, so the above call is correct... did you clean the assets folder ?

@ghost ghost assigned mdomba Jul 31, 2012

@alxkolm

This comment has been minimized.

Show comment
Hide comment
@alxkolm

alxkolm Jul 31, 2012

yes, but bug still

alxkolm commented Jul 31, 2012

yes, but bug still

@mdomba

This comment has been minimized.

Show comment
Hide comment
@mdomba

mdomba Jul 31, 2012

Member

https://github.com/yiisoft/yii/blob/master/framework/zii/widgets/assets/gridview/jquery.yiigridview.js#L76

This is the line that makes the replacement... check that you have this version in your assets folder

Member

mdomba commented Jul 31, 2012

https://github.com/yiisoft/yii/blob/master/framework/zii/widgets/assets/gridview/jquery.yiigridview.js#L76

This is the line that makes the replacement... check that you have this version in your assets folder

@alxkolm

This comment has been minimized.

Show comment
Hide comment
@alxkolm

alxkolm Jul 31, 2012

sorry, there are old jquery.yiigridview.js

alxkolm commented Jul 31, 2012

sorry, there are old jquery.yiigridview.js

@alxkolm

This comment has been minimized.

Show comment
Hide comment
@alxkolm

alxkolm commented Jul 31, 2012

thanks

@alxkolm alxkolm closed this Jul 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment