Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while parsing MO files with no context #145

Closed
qiangxue opened this issue Feb 15, 2012 · 1 comment
Closed

Error while parsing MO files with no context #145

qiangxue opened this issue Feb 15, 2012 · 1 comment
Labels
type:bug
Milestone
1.1.11 release

Comments

@qiangxue
Copy link
Member

Hello, I'm detected a problem while parsing MO files to use Gettext on i18n.
Apparently the CGettextMoFile::load method ignores that can exist source messages with no context in a MO file.

I'm using Yii 1.1.7.

I attach a patch that solves the problem for me.

Kind regards!
Damián

Migrated from http://code.google.com/p/yii/issues/detail?id=2288

earlier comments

qiang.xue said, at 2012-01-01T03:36:54.000Z:

set for 1.1.10 milestone
dnohales added a commit to dnohales/yii that referenced this issue Feb 22, 2012
@dnohales
CGettextMoFile now takes in account the absence of context in strings.
a16e772 
Fix for the issue yiisoft#145.
Now when pass an invalid context (eg. NULL or false) to CGettextMoFile::load
the method will get the strings without context.
@dnohales dnohales mentioned this issue Feb 22, 2012
Merged
dnohales added a commit to dnohales/yii that referenced this issue Feb 23, 2012
@dnohales
Modified CHANGELOG for CGettextMoFile fix (issue yiisoft#145).
936fa98
cebe added a commit to cebe/yii that referenced this issue Feb 28, 2012
@cebe
Merge branch 'master' of https://github.com/yiisoft/yii into 286-cdat…
b181ced 
…etimeparser-wildcard

* 'master' of https://github.com/yiisoft/yii:
  doc fixes for proper PDF creation
  Sometimes CJSON::decode returns null because native json_encode has bugs and returns null. Workaround to continue decoding when result of json_decode is null. Fixes yiisoft#295
  Changelog amending, renaming CLinkPager CSS properties
  Modified CHANGELOG for CGettextMoFile fix (issue yiisoft#145).
  CGettextMoFile now takes in account the absence of context in strings.
  Returned CLinkPager::CSS_* constants, fixed documentation.
  CLinkPager::CSS_* constants replaced by public properties
  tried to improve naming
  docs, rename: function -> method
  improved docs and variable names of CDetailView
  added changelog for CDetailView changes
  added @ since annotation
  improved extendability of CDetailView

Conflicts:
	CHANGELOG
@qiangxue
Copy link
Member Author

qiangxue commented Mar 1, 2012

Fixed by #388

@qiangxue qiangxue closed this as completed Mar 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
1.1.11 release
Development

No branches or pull requests
1 participant
@qiangxue