1.1.13 filterSelector event (in yiiGridView) doesn't return false for custom filter forms #1909

matih opened this Issue Jan 1, 2013 · 1 comment


None yet

3 participants


In the new feature to use an external form to filter the GridView with the CBaseListView::$filterSelector, the JS event (onchange/onkeydown) needed to return false in order to prevent the default action - namely prevent the custom form from submitting by filling a field and pressing Enter.

Like a click on the updateSelector - that returns false:

$(document).on('click.yiiGridView', settings.updateSelector, function () {
return false;

Currently, I need to put :

return false;

@mdomba mdomba was assigned Jun 24, 2013
@resurtm resurtm closed this in 3bf5ca3 Jun 29, 2013

I see no reason not to fix this as it was proposed by @matih. I have tested it intensively and didn't found any possible pitfalls.

@matih, thanks for proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment