New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFileLogRoute strange '?+' in stack trace #213

Closed
qiangxue opened this Issue Feb 15, 2012 · 7 comments

Comments

Projects
None yet
3 participants
@qiangxue
Member

qiangxue commented Feb 15, 2012

2011/06/30 11:16:12 [error] [exception.CHttpException.403] exception 'CHttpException' with message 'У вас недостаточно прав для выполнения указанного действия.' in /var/www/creocoder/data/frameworks/yii-1.1.8.r3324/yiilite.php:6223
Stack trace:
#0 /var/www/creocoder/data/frameworks/yii-1.1.8.r3324/yiilite.php(6203): CAccessControlFilter->accessDenied(Object(CWebUser), '?? ?????? ?????...')

...
#11 {main} REQUEST_URI=/admin/advCategory/index

Check this line right part:
>CAccessControlFilter->accessDenied(Object(CWebUser), '?? ?????? ?????...')

Migrated from http://code.google.com/p/yii/issues/detail?id=2601


earlier comments

creocoder said, at 2011-07-01T14:37:24.000Z:

Minimal code to reproduce. Place in empty action: $this->notExistsMethod('тестовая строка');

Result:

Stack trace:
#0 \protected\controllers\TestController.php(6):
CComponent->__call('notExistsMethod', Array)
#1 \protected\controllers\TestController.php(6):
TestController->notExistsMethod('???????????????...')

Note: CWebLogRoute also has this bug.

alexander.makarow said, at 2011-07-07T00:01:14.000Z:

Both Exception::getTraceAsString and Exception::__toString can't handle unicode characters so the only possible fix is to build exception string manually: concatenating message, file, line and traversing arguments.

qiang.xue said, at 2012-01-01T03:37:10.000Z:

set for 1.1.10 milestone

qiang.xue said, at 2012-01-01T03:37:35.000Z:

set for 1.1.10 milestone

@ghost ghost assigned samdark Mar 9, 2012

@mdomba

This comment has been minimized.

Show comment
Hide comment
@mdomba

mdomba Mar 11, 2012

Member

do we need to do this... the problem is only that the unicode letters are displayed as ?... but to the developer the file line number and the method called should be enough to debug his code...

Member

mdomba commented Mar 11, 2012

do we need to do this... the problem is only that the unicode letters are displayed as ?... but to the developer the file line number and the method called should be enough to debug his code...

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Mar 11, 2012

Member

Let's close this for now. It doesn't work the effort to fix this issue since it is very rare.

Member

qiangxue commented Mar 11, 2012

Let's close this for now. It doesn't work the effort to fix this issue since it is very rare.

@qiangxue qiangxue closed this Mar 11, 2012

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Mar 12, 2012

Member

Since it's valid, let's keep it open. Removed milestone.

Member

samdark commented Mar 12, 2012

Since it's valid, let's keep it open. Removed milestone.

@samdark samdark reopened this Mar 12, 2012

@mdomba

This comment has been minimized.

Show comment
Hide comment
@mdomba

mdomba Mar 12, 2012

Member

But why keep it open... as I pointed above... does it even make sense on fixing this?

This issue is seen only by developers... and to them it's enough the file and line number... what problem does it make if you don't see the exact value of the parameter ?

I really don't see the point of keeping this issue open.

Member

mdomba commented Mar 12, 2012

But why keep it open... as I pointed above... does it even make sense on fixing this?

This issue is seen only by developers... and to them it's enough the file and line number... what problem does it make if you don't see the exact value of the parameter ?

I really don't see the point of keeping this issue open.

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Mar 12, 2012

Member

We better let PHP fix it.

Member

qiangxue commented Mar 12, 2012

We better let PHP fix it.

@qiangxue qiangxue closed this Mar 12, 2012

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Mar 12, 2012

Member

@mdomba it can be that you'll get line and fine from your log but will not be able to reproduce it because you don't know what parameter value is.

@qiangxue Makes sense. I'll make sure there's a bug report at php.net.

Member

samdark commented Mar 12, 2012

@mdomba it can be that you'll get line and fine from your log but will not be able to reproduce it because you don't know what parameter value is.

@qiangxue Makes sense. I'll make sure there's a bug report at php.net.

@samdark

This comment has been minimized.

Show comment
Hide comment
Member

samdark commented Mar 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment