GridView JS problem with custom template

[buakos]

The fix for #769 and #1225 seems to be somewhat incomplete.

There are (at least) 4 more places to replace children with find:

1. selectCheckedRows
2. the event handler for .select-on-check-all click
3. getRow
4. getColumn

I think there is no more place, but essentially everywhere settings.tableClass is the selector the code should search also in deeper levels.

Without these changes the check-all box and the other functions do not work correctly with a custom template like this:
<div class="items-wrapper">{items}</div>

[mdomba]

Please give more details as what does not work for you... also provide the complete grid code.

I just set on one a grid 'template' => '<div class="items-wrapper">{items}</div>',

and the "check all" works as expected... also selecting all rows checks the checkboxes of those rows and the "check all" box.

[buakos]

You can try eg. this one:

$rawData = array(
  array('name' => 'Name1', 'value' => 'Value1'),
  array('name' => 'Name2', 'value' => 'Value2'),
  array('name' => 'Name3', 'value' => 'Value3'),
);
$dataProvider = new CArrayDataProvider($rawData, array(
  'keyField' => false,
  ));
$template = '<div class="items-wrapper">{items}</div>';

$this->widget('zii.widgets.grid.CGridView', array(
  'id' => 'test-grid',
  'dataProvider' => $dataProvider,
  'selectableRows' => 2,
  'template' => $template,
  'columns' => array(
    array(
      'class' => 'CCheckBoxColumn',
    ),
    'name',
    'value',
  ),
)); 

As you can see, checking the box does not select any rows (only checks the boxes without adding the selected class). Also the getRow and getColumn methods return incorrect results.

[mdomba]

right, issue confirmed...

I was clicking directly on the row and then it was working, the check-all click is not working...

Request a PR and we will merge the changes...

[buakos]

OK, thanks!