Enable/disable foreign key constraings for sqlite. #1449

Closed
wants to merge 5 commits into
from

4 participants

Owner

Could you update the CHANGELOG file accordingly? Thanks.

Done.

Owner
cebe commented Sep 21, 2012

As stated in #1447 this is not supported by older sqlite versions, we need to make sure it does not break applications using old sqlite versions.

Contributor
resurtm commented Sep 21, 2012

And of course, unit tests as always are very welcome! ;-)

@resurtm resurtm was assigned Mar 26, 2013
@resurtm resurtm added a commit that referenced this pull request Mar 26, 2013
@resurtm resurtm Enh #1447: CSqliteSchema: added enabling/disabling integrity check fo…
…r sqlite. PR #1449.
33763f8
Contributor
resurtm commented Mar 26, 2013

Merged manually: 33763f8

@resurtm resurtm closed this Mar 26, 2013
Contributor
resurtm commented Mar 26, 2013

@cebe:

we need to make sure it does not break applications using old sqlite versions

It won't. This case is unit tested (1b24643).

Owner
cebe commented Mar 26, 2013

It won't. This case is unit tested (1b24643).

@resurtm also with sqlite < 3.7.10 ?

Contributor
resurtm commented Mar 27, 2013

@cebe, i did some tests on PHP 5.2 (sqlite 3.3.7) and on PHP 5.4 (sqlite 3.7.7.1):

  1. Testing script: http://pastebin.com/dBngz3CA
  2. PHP 5.2 (sqlite 3.3.7): http://pastebin.com/6uYMNGZ5
  3. PHP 5.4 (sqlite 3.7.7.1): http://pastebin.com/q3X3vyDa

Looks good to me. Btw, note that default sqlite version bundled with the latest PHP 5.2 is 3.3.7—our unit tests are all right.

Owner
cebe commented Mar 27, 2013

Okay, cool :) Thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment