Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CHtml::$closeSingleTags and CHtml::$renderSpecialAttributesValue added #1518

Merged
merged 4 commits into from Oct 2, 2012

Conversation

4 participants
Contributor

creocoder commented Oct 2, 2012

Allow using short single tags without close it:

For example:

<img src="..." alt="">

VS

<img src="..." alt="" />

Allow no render special attributes value:

For example:

<input name="..." disabled="disabled">

VS

<input name="..." disabled>

Give us pure html5 features!

@ghost ghost assigned samdark Oct 2, 2012

@samdark samdark added a commit that referenced this pull request Oct 2, 2012

@samdark samdark Merge pull request #1518 from creocoder/chtml-enh
[ci skip] CHtml::$closeSingleTags and CHtml::$renderSpecialAttributesValue added
ab2ed50

@samdark samdark merged commit ab2ed50 into yiisoft:master Oct 2, 2012

Owner

samdark commented Oct 2, 2012

Thanks for working on it.

@mdomba mdomba commented on the diff Oct 2, 2012

framework/web/helpers/CHtml.php
@@ -74,7 +74,17 @@ class CHtml
* @since 1.1.9
* @see clientChange
*/
- public static $liveEvents = true;
+ public static $liveEvents=true;
+ /*
+ * @var boolean whether to close single tags. Defaults to true. Can be setted to false for HTML5.
@mdomba

mdomba Oct 2, 2012

Member

is it setted or set?

@cebe

cebe Oct 2, 2012

Owner

has to be set. fixed in 0955e63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment