PHPDoc-Complete Comments for Controller Template #1539

Merged
merged 2 commits into from Oct 6, 2012

Conversation

Projects
None yet
2 participants
Contributor

DaSourcerer commented Oct 6, 2012

The title pretty much says it: This PR completes the PHPdoc in the controller template, which in turn will reduce the number of warnings in editors that parse them.

@@ -153,7 +153,9 @@ public function actionAdmin()
/**
* Returns the data model based on the primary key given in the GET variable.
* If the data model is not found, an HTTP exception will be raised.
- * @param integer the ID of the model to be loaded
+ * @param integer $id the ID of the model to be loaded
+ * @return CModel the loaded model
@samdark

samdark Oct 6, 2012

Owner

I think it should be particular model class.

@@ -165,7 +167,7 @@ public function loadModel($id)
/**
* Performs the AJAX validation.
- * @param CModel the model to be validated
+ * @param CModel $model the model to be validated
@samdark

samdark Oct 6, 2012

Owner

Same here.

@DaSourcerer

DaSourcerer Oct 6, 2012

Contributor

Done with 79fdf1d

@ghost ghost assigned samdark Oct 6, 2012

samdark added a commit that referenced this pull request Oct 6, 2012

Merge pull request #1539 from DaSourcerer/gii-template-phpdoc
PHPDoc-Complete Comments for Controller Template

@samdark samdark merged commit 51333b6 into yiisoft:master Oct 6, 2012

Owner

samdark commented Oct 6, 2012

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment