Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

CHtml::cssFile() url fix 2 #1542

Merged
merged 1 commit into from

3 participants

@creocoder

No description provided.

@samdark samdark merged commit a48a1cc into yiisoft:master
@cebe
Owner

@creocoder @samdark whats the problem with this? a description would have been nice ;)

Also when I have apersands in my url they should be encoded as & I think. Why did you remove it?

@samdark
Owner

It's a fix for a fix that resulted in unit tests breakage.

@cebe
Owner

seen that (#1540). Re-checked and found that linkTag encodes attributes by default so encode here will result in double encoding. Everything is fine though.

@creocoder

@cebe Yes, all fine there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 6, 2012
  1. @creocoder

    CHtml::cssFile() url fix

    creocoder authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  framework/web/helpers/CHtml.php
View
2  framework/web/helpers/CHtml.php
@@ -270,7 +270,7 @@ public static function refresh($seconds, $url='')
*/
public static function cssFile($url,$media='')
{
- return CHtml::linkTag('stylesheet','text/css',self::encode($url),$media!=='' ? $media : null);
+ return CHtml::linkTag('stylesheet','text/css',$url,$media!=='' ? $media : null);
}
/**
Something went wrong with that request. Please try again.