Add filterSelector to CGridView #1618

Closed
wants to merge 3 commits into from

2 participants

@mdomba

why is this line added here ?

@mdomba

check the updateSelector documentation and in similar style please add an example here, also we can use the same line Note: if this value is empty an exception will be thrown. and check that in the code like it's done for updateSelector, this way in the JS code there is no need to check if this property is empty - because it makes no sense to have filters on the grid and then set this property to empty.

@mdomba

destroy is a separate issue, please make this PR only about filterSelector as discussed in this issue, for destroy you can open a new issue and then we can decide if it's needed and if to add it. IMO this functionality is not needed in the core.

@mdomba

the value of filterselector is passed from the PHP part, so it's always set, no need to add the || '' part here.

@mdomba

no need to check for length - same as with inputSelector

@MonkeyMaster

@mdomba I implemented your comments
and I didn't add that line with @version $Id$ - I followed yii workflow
(got new suprises from github windows application)

@mdomba
Yii Software LLC member

the PHP code is good, but jquery.yiigridview.js cannot be reviewed because of the cr/lf problem, now the whole file is marked as changed so it's not possible to see just the changes - files

@mdomba
Yii Software LLC member

Closing this as there is a new PR - #1619

@mdomba mdomba closed this Oct 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment