Add filterSelector to CGridView #1619

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@MonkeyMaster

Resolves issue #1567
Attempt 2 (attempts 1 is #1618)

@mdomba

This comment has been minimized.

Show comment Hide comment
@mdomba

mdomba Oct 27, 2012

Member

Great, this PR is "clean"...

please add a line to the CHANGELOG file (check the guidelines to make it properly)

Member

mdomba commented Oct 27, 2012

Great, this PR is "clean"...

please add a line to the CHANGELOG file (check the guidelines to make it properly)

@MonkeyMaster

This comment has been minimized.

Show comment Hide comment
@MonkeyMaster

MonkeyMaster Oct 27, 2012

I had no luck with git reset --hard due to git push complaining about no-fast-forward or something so a fresh start...

I had no luck with git reset --hard due to git push complaining about no-fast-forward or something so a fresh start...

@Ryadnov

This comment has been minimized.

Show comment Hide comment
@Ryadnov

Ryadnov Oct 28, 2012

Contributor
Contributor

Ryadnov commented Oct 28, 2012

@MonkeyMaster

This comment has been minimized.

Show comment Hide comment
@MonkeyMaster

MonkeyMaster Oct 28, 2012

I didn't touch that lines with 'elseif' - have no idea where that changes come from

I didn't touch that lines with 'elseif' - have no idea where that changes come from

framework/zii/widgets/grid/CGridView.php
+ *
+ * @since 1.1.13
+ */
+ public $filterSelector='{filters}';

This comment has been minimized.

Show comment Hide comment
@mdomba

mdomba Oct 29, 2012

Member

Just noticed... it's better to use singular form as we used elsewhere, so it should be '{filter}'

@mdomba

mdomba Oct 29, 2012

Member

Just noticed... it's better to use singular form as we used elsewhere, so it should be '{filter}'

framework/zii/widgets/grid/CGridView.php
@@ -236,9 +236,25 @@ class CGridView extends CBaseListView
*/
public $loadingCssClass='grid-view-loading';
+ /**
+ * @var string the jQuery selector of filter input fields. Defaults to '{filters}', that
+ * will be replaced with selector for internal grid filters.

This comment has been minimized.

Show comment Hide comment
@mdomba

mdomba Oct 29, 2012

Member

The token '{filter}' is recognized and it will be replaced with the grid filters selector.

@mdomba

mdomba Oct 29, 2012

Member

The token '{filter}' is recognized and it will be replaced with the grid filters selector.

@mdomba

This comment has been minimized.

Show comment Hide comment
@mdomba

mdomba Nov 14, 2012

Member

Merged manually 940836b

Thanks for working on this...

Member

mdomba commented Nov 14, 2012

Merged manually 940836b

Thanks for working on this...

@mdomba mdomba closed this Nov 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment