Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

array_push optimizations #1917

Merged
merged 11 commits into from Jan 26, 2013

Conversation

3 participants
Contributor

and-ers commented Jan 3, 2013

Submitted the old changes to the php pear project.

Well the commit 0a7206e is perhaps more relevant then?

@ghost ghost assigned samdark Jan 3, 2013

@samdark samdark commented on an outdated diff Jan 7, 2013

tests/framework/db/schema/COciTest.php
@@ -73,13 +73,15 @@ public function setUp()
}
$sqls='';
- foreach(explode("\n", file_get_contents($schemaFilePath)) as $line)
+ $lines = explode("\n", file_get_contents($schemaFilePath))
+ foreach( as $line)
@samdark

samdark Jan 7, 2013

Owner

$lines missing.

@samdark samdark commented on an outdated diff Jan 7, 2013

framework/gii/components/Pear/Text/Diff/Engine/shell.php
@@ -86,34 +86,34 @@ function diff($from_lines, $to_lines)
@samdark

samdark Jan 7, 2013

Owner

This file should not be here. Will merge it from PEAR later.

samdark added a commit that referenced this pull request Jan 26, 2013

@samdark samdark merged commit 157ff01 into yiisoft:master Jan 26, 2013

Owner

samdark commented Jan 26, 2013

Merged. Thanks!

Contributor

Yiivgeny commented Jan 29, 2013

@samdark, PR contain error.
Application crashed when call CVarDumper::dump with objects. E.g. CVarDumper::dump(new StdClass)

$id now contain object, not count objects.

Recoverable error
Object of class stdClass could not be converted to string 
/vendors/Yii/framework/utils/CVarDumper.php(128)

samdark added a commit that referenced this pull request Jan 29, 2013

Merge pull request #1917 from and-ers/master
array_push optimizations (reverse-merged from commit 157ff01)
Owner

samdark commented Jan 29, 2013

Thanks for testing. Reverted. It doesn't make sense to count afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment