Move gii application components to beforeAction #1958

Closed
wants to merge 1 commit into
from

Conversation

2 participants
Owner

cebe commented Jan 11, 2013

GiiModule should only adjust environment when it actually runs a
controller action. It should not affect app in other cases.

see issue #1906 for details

@cebe cebe Move gii application components to beforeAction
GiiModule should only adjust environment when it actually runs a
controller action. It should not affect app in other cases.

see issue #1906 for details
4ab3221

cebe referenced this pull request Jan 11, 2013

Closed

1.1.13 bug in setComponents #1906

Owner

cebe commented Jan 11, 2013

What is different after this change, that unrouteable requests will not show a gii error page but the application error page, but I think that is acceptable.

Owner

qiangxue commented Jan 11, 2013

I don't quite like this change because the workflow is completely changed to something unusual.
Yes, it does fix the original issue. But the issue is very rare: the gii module is NOT designed to be invoked in other code. Gii is designed as a module mainly because we want it to inherit part of the Web app running environment. Otherwise, we would create an independent application rather than a module.

cebe was assigned Jan 11, 2013

Owner

cebe commented Apr 24, 2013

Okay, closing it then.

cebe closed this Apr 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment