add `y` pattern to CDateTimeParser #2119

Closed
wants to merge 1 commit into
from

4 participants

@mrpelle
Contributor
mrpelle commented Feb 15, 2013

This PR resolves the issue of parsing strings ending with a 4-digits-year when "short" format is set to dd/MM/y.

See #1436

@mrpelle
Contributor
mrpelle commented Mar 27, 2013

Any news on this?

@resurtm
Contributor
resurtm commented Mar 28, 2013

Not sure the fix is so obvious. In #1436 there is URL: http://www.unicode.org/cldr/trac/ticket/5347

Pedberg said:

This is fixed for CLDR 23. Note that a single 'y' will still parse a 4-digit year (or a 3-digit or 5-digit year...), in addition to formatting using as many digits as necessary with zero-padding.

I'm confused with the following part: a 4-digit year (or a 3-digit or 5-digit year...). This is not what you have in your patch.

@cebe
Member
cebe commented Mar 28, 2013

What is a 3-digit or 5-digit year? Do we really go that far into future/past?

@qiangxue
Member

Postponed to 1.1.15.

@cebe cebe added a commit that closed this pull request Oct 23, 2014
@mrpelle @cebe mrpelle + cebe add `y` pattern to CDateTimeParser
close #2119
6e4a51a
@cebe cebe closed this in 6e4a51a Oct 23, 2014
@cebe
Member
cebe commented Oct 23, 2014

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment