Fixes #289: Gii module could be submodule of an another module. #2278

Merged
merged 3 commits into from Apr 23, 2013

Conversation

3 participants
Contributor

resurtm commented Mar 30, 2013

Fixes #289: Gii module could be submodule of an another module.

resurtm was assigned Mar 30, 2013

@klimov-paul klimov-paul commented on an outdated diff Apr 22, 2013

@@ -5,6 +5,7 @@ Version 1.1.14 work in progress
-------------------------------
- Bug #135: Fixed wrong CActiveRecord rows count with having (klimov-paul)
- Bug #150: Fixed CWidget was not switching between view paths when using themes (antoncpu)
+- Bug #289: Gii module could be submodule of an another module (resurtm)
@klimov-paul

klimov-paul Apr 22, 2013

Member

Issue #289 is not a bug, it is an enhancement.

Member

klimov-paul commented Apr 22, 2013

Looks good, except the CHANGELOG.

Vote for merging this.
Even if do not mind on the ability of using Gii as submodule for another module, this PR changes the Gii code in the way it cold serve a living example of how the modules should be made.

Contributor

resurtm commented Apr 22, 2013

@klimov-paul, thanks! I'd like to check and test it once more before merging.

Member

klimov-paul commented Apr 22, 2013

I have tested this PR successfully standalone and inside the module.
Seems to work fine.

Owner

samdark commented Apr 23, 2013

Great, feel free to merge it.

@resurtm resurtm added a commit that referenced this pull request Apr 23, 2013

@resurtm resurtm Merge pull request #2278 from resurtm/fixes-289
Fixes #289: Gii module could be submodule of an another module.
c7dc2b4

@resurtm resurtm merged commit c7dc2b4 into yiisoft:master Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment