New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: CDbCacheDependency with reuseDependentData did not invalidate cache when getting cache across different requests #2290

Merged
merged 13 commits into from Apr 12, 2013

FIX: CDbCacheDependency with reuseDependentData did not invalidate ca…

…che when getting cache across different requests (marcovtwout)
  • Loading branch information...
marcovtwout committed Apr 3, 2013
commit 7194f9a6daae137c3e076f4fb6e4778d2d36b1c5
View
@@ -40,6 +40,7 @@ Version 1.1.14 work in progress
- Bug #2244: MessageCommand has been updated, allowing to merge string with value '0' correctly (klimov-paul)
- Bug #2258: CJuiSliderInput didn't support string typed 'range' option (bookin)
- Bug #2283: Gii Model Generator's tooltips are not working and always invisible (resurtm)
- Bug #2289: CDbCacheDependency with reuseDependentData did not invalidate cache when getting cache across different requests (marcovtwout)
- Enh: Better CFileLogRoute performance (Qiang, samdark)
- Enh: Refactored CHttpRequest::getDelete and CHttpRequest::getPut not to use _restParams directly (samdark)
- Enh #1142: CSecurityManager::computeHMAC() has been made public (resurtm)
@@ -69,13 +69,9 @@ public function getHasChanged()
if ($this->reuseDependentData)
{
$hash=$this->getHash();
if (!isset(self::$_reusableData[$hash]['hasChanged']))
{
if (!isset(self::$_reusableData[$hash]['dependentData']))
self::$_reusableData[$hash]['dependentData']=$this->generateDependentData();
self::$_reusableData[$hash]['hasChanged']=self::$_reusableData[$hash]['dependentData']!=$this->_data;
}
return self::$_reusableData[$hash]['hasChanged'];
if (!isset(self::$_reusableData[$hash]['dependentData']))

This comment has been minimized.

@samdark

samdark Apr 9, 2013

Member

Extra space before (.

@samdark

samdark Apr 9, 2013

Member

Extra space before (.

self::$_reusableData[$hash]['dependentData']=$this->generateDependentData();
return self::$_reusableData[$hash]['dependentData']!=$this->_data;
}
else
return $this->generateDependentData()!=$this->_data;
ProTip! Use n and p to navigate between commits in a pull request.