bugfix #449 db logs and session use commands #500

Closed
wants to merge 5 commits into
from

Conversation

3 participants

Issue #449
backward compatible, no extended error handling. Merged with latest changes.

Member

mdomba commented Mar 14, 2012

It's too hard to review your latest pull because with this one you are fixing the code you added on the previous one that was rejected... then for example in the latest pull the createSessionTable() has the code that calculates the $blob variable marked as "new code" but that code is already in the current Yii code... and in the end youo are merging with all the changes made recently...

To make this simpler and cleaner for the dev teamto review... please make on your side a new branch from the current Yii code and then apply just the query builder...

I will leave this open for now so other dev. members can take a look too, maybe I missed something, but I can't see how to review/analize this code effectively.

Owner

samdark commented Mar 16, 2012

It looks like something is wrong with your fork since you have lots of changes that aren't yours in your commits. Because of that we can't review what was done. Please open another pull request starting from a new fork. Thanks.

samdark closed this Mar 16, 2012

I just followed instructions from:
https://github.com/yiisoft/yii/wiki/Git-workflow-for-Yii-contributors for
the for I had created earlier.
when I did pull from mainstream (9) there were some conflicts which I
resolved and pushed new commit (10). After that I just reopened pull
request on main repo (11)... I did not copy those new changes other way.
Maybe there is something wrong with this instructions? I am new to git
(heavily using just svn), so I followed instructions step-by-step...

W dniu 16 marca 2012 10:40 uytkownik Alexander Makarov <
reply@reply.github.com

napisa:

It looks like something is wrong with your fork since you have lots of
changes that aren't yours in your commits. Because of that we can't review
what was done. Please open another pull request starting from a new fork.
Thanks.


Reply to this email directly or view it on GitHub:
#500 (comment)

Member

mdomba commented Mar 16, 2012

All those additional commits are from other accepted pull requests made in the meantime...

But the main problem to review your change is that you are now fixing (removing) the code you added in the previous pull request...

As that pull request was rejected and closed... you need to create a new branch on your side and apply the needed changes... so we can review the changes in compare to the current Yii code...

Currently your changes are compared to your previous pull request.

ok. no problem with another branch and another pull request.

W dniu 16 marca 2012 10:54 uytkownik Maurizio Domba <
reply@reply.github.com

napisa:

All those additional commits are from other accepted pull requests made in
the meantime...

But the main problem to review your change is that you are now fixing
(removing) the code you added in the previous pull request...

As that pull request was rejected and closed... you need to create a new
branch on your side and apply the needed changes... so we can review the
changes in compare to the current Yii code...

Currently your changes are compared to your previous pull request.


Reply to this email directly or view it on GitHub:
#500 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment