Fix #56: configure Codeception::Scpecify to not deep clone properties by default #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cherifGsoul
commented
May 17, 2016
cherifGsoul
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #56 |
|
@cebe Im confused, you are refering the PR as a bug you mean it has as bug or it corrects a bug? |
|
labeling as bug means that it fixes a bug. it is just for us internally to manage issues better. bugs have slightly higher priority for merging and reviewing than features. |
|
thank you :) |
|
Merged, thank you! |
|
Thanks :) |
|
This change made Codeception's --prefer-lowest builds fail. |
Naktibalda
added a commit
to Naktibalda/yii2-app-basic
that referenced
this pull request
Jul 16, 2016
It was an indirect dependency and yiisoft#57 made Codeception builds with --prefer-lowest fail: https://travis-ci.org/Codeception/Codeception/jobs/145152589#L1653
Naktibalda
added a commit
to Naktibalda/yii2-app-basic
that referenced
this pull request
Jul 16, 2016
It was an indirect dependency and yiisoft#57 made Codeception builds with --prefer-lowest fail: https://travis-ci.org/Codeception/Codeception/jobs/145152589#L1653
samdark
pushed a commit
that referenced
this pull request
Jul 17, 2016
It was an indirect dependency and #57 made Codeception builds with --prefer-lowest fail: https://travis-ci.org/Codeception/Codeception/jobs/145152589#L1653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.