New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch users #205

Merged
merged 19 commits into from Apr 26, 2017

Conversation

@sam002
Contributor

sam002 commented Feb 21, 2017

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #204

@samdark samdark self-assigned this Feb 21, 2017

@samdark samdark added this to the 2.0.10 milestone Feb 21, 2017

Show outdated Hide outdated Module.php
@@ -0,0 +1 @@
<svg xmlns:svg="http://www.w3.org/2000/svg" xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 50 50" version="1.1"><path d="m41.1 23c-0.6 0-1 0.4-1 1v10.7l-25.6-0.1c0 0 0-2 0-2.8 0-0.8-0.7-1-1-0.6l-3.5 3.5c-0.6 0.6-0.6 1.3 0 2l3.4 3.4c0.4 0.4 1.1 0.2 1-0.6l0-2.9c0 0 20.8 0.1 26.6 0 0.6 0 1-0.4 1-1v-11.7c0-0.6-0.4-1-1-1zM9 26.9 9 26.9 9 26.9 9 26.9"/><path d="m9 26.9c0.6 0 1-0.4 1-1v-10.7l25.6 0.1c0 0 0 2 0 2.8 0 0.8 0.7 1 1 0.6l3.5-3.5c0.6-0.6 0.6-1.3 0-2l-3.4-3.4c-0.4-0.4-1.1-0.2-1 0.6l0 2.9c0 0-20.8-0.1-26.6 0-0.6 0-1 0.4-1 1v11.7c0 0.6 0.4 1 1 1z"/></svg>

This comment has been minimized.

@samdark

samdark Feb 24, 2017

Member

Doesn't seem to be used anywhere.

@samdark

samdark Feb 24, 2017

Member

Doesn't seem to be used anywhere.

This comment has been minimized.

@samdark

samdark Feb 25, 2017

Member

OK, let's have it then.

@samdark

samdark Feb 25, 2017

Member

OK, let's have it then.

Show outdated Hide outdated controllers/UserController.php
Show outdated Hide outdated controllers/UserController.php
Show outdated Hide outdated docs/guide/installation.md
Show outdated Hide outdated docs/guide/installation.md
Show outdated Hide outdated models/UserSwitch.php
Show outdated Hide outdated panels/UserPanel.php
Show outdated Hide outdated views/default/panels/user/switch.php
Show outdated Hide outdated views/default/panels/user/switch.php
Show outdated Hide outdated views/default/panels/user/switch.php
@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Feb 26, 2017

Member

Code looks good to me overall. Naming isn't perfect though.

qip shot - screen 565

Member

samdark commented Feb 26, 2017

Code looks good to me overall. Naming isn't perfect though.

qip shot - screen 565

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Apr 24, 2017

Member

Please add a line for changelog.

Member

samdark commented Apr 24, 2017

Please add a line for changelog.

@sam002

This comment has been minimized.

Show comment
Hide comment
@sam002

sam002 Apr 24, 2017

Contributor

@samdark, done.

Contributor

sam002 commented Apr 24, 2017

@samdark, done.

@samdark samdark merged commit 959a651 into yiisoft:master Apr 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Apr 26, 2017

Member

Merged. Thank you very much!

Member

samdark commented Apr 26, 2017

Merged. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment