-
-
Notifications
You must be signed in to change notification settings - Fork 192
improved generation annotation of properties #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: uldisn <uldisnelsons@gmail.com>
|
Thank you for putting effort in the improvement of the Yii framework. Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework. Could you supply us with a use case please? Please be as detailed as possible and show some code! Thanks! This is an automated comment, triggered by adding the label |
|
Updated: #416 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK. Please add lines for changelog.md and I'll merge it.
Signed-off-by: uldisn <uldisnelsons@gmail.com>
Done |
|
Merged. Thank you! |
Fix yiisoft#416: Improved generation of model attributes and type annotations
Signed-off-by: uldisn uldisnelsons@gmail.com
New features
added type float (MySql: decimal, float, money, double)
If column value can be null, property type for example for string column set like this
Bug
For MySql table
Properties $id and $delivery_id type is generated as string, but must be integer