New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMQP interop based driver. #158

Merged
merged 17 commits into from Dec 5, 2017

Conversation

Projects
None yet
4 participants
@makasim
Contributor

makasim commented Oct 25, 2017

Advantages:

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Oct 25, 2017

Contributor

I'll work on tests and other stuff once we agree in general on this matter.

Contributor

makasim commented Oct 25, 2017

I'll work on tests and other stuff once we agree in general on this matter.

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Oct 26, 2017

Contributor

@samdark @zhuravljov could you please have a look?

Contributor

makasim commented Oct 26, 2017

@samdark @zhuravljov could you please have a look?

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Oct 26, 2017

Member

I don't have enough experience do decide on this one in general so @zhuravljov this one is yours. I'll check code in general.

Member

samdark commented Oct 26, 2017

I don't have enough experience do decide on this one in general so @zhuravljov this one is yours. I'll check code in general.

Show outdated Hide outdated src/drivers/amqp/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp/Queue.php Outdated

@makasim makasim referenced this pull request Oct 26, 2017

Open

Proposals #4

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Oct 26, 2017

Contributor

This implementation also supports new features: ttr, attempts, delays, priorities.

Contributor

makasim commented Oct 26, 2017

This implementation also supports new features: ttr, attempts, delays, priorities.

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Oct 30, 2017

Contributor

@zhuravljov I was wondering if you have you got time to look into this PR?

Contributor

makasim commented Oct 30, 2017

@zhuravljov I was wondering if you have you got time to look into this PR?

Show outdated Hide outdated src/drivers/amqp/Queue.php Outdated
@zhuravljov

This comment has been minimized.

Show comment
Hide comment
@zhuravljov

zhuravljov Nov 1, 2017

Member

@makasim thank you for contribution, I will look and test soon.

Member

zhuravljov commented Nov 1, 2017

@makasim thank you for contribution, I will look and test soon.

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 1, 2017

Contributor

Added:

  • Contains new options like: vhost, connection_timeout, qos_prefetch_count and so on.
  • Supports Secure (SSL) AMQP connections.
  • Add ability to set DSN like: amqp:, amqps: or amqp://user:pass@localhost:1000/vhost
Contributor

makasim commented Nov 1, 2017

Added:

  • Contains new options like: vhost, connection_timeout, qos_prefetch_count and so on.
  • Supports Secure (SSL) AMQP connections.
  • Add ability to set DSN like: amqp:, amqps: or amqp://user:pass@localhost:1000/vhost
@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 15, 2017

Contributor

Would it be easier for you to review it if I, instead of changing existing class, create new ones?

Contributor

makasim commented Nov 15, 2017

Would it be easier for you to review it if I, instead of changing existing class, create new ones?

@makasim makasim changed the title from Amqp interop based driver. to Add AMQ interop based driver. Nov 17, 2017

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 19, 2017

Contributor

A test fail is not related to my changes.

Contributor

makasim commented Nov 19, 2017

A test fail is not related to my changes.

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 29, 2017

Contributor

@samdark @zhuravljov @thiagotalma I addressed all review comments.

Contributor

makasim commented Nov 29, 2017

@samdark @zhuravljov @thiagotalma I addressed all review comments.

Show outdated Hide outdated CHANGELOG.md Outdated
Show outdated Hide outdated docs/guide/README.md Outdated
Show outdated Hide outdated docs/guide/driver-amqp-interop.md Outdated
/**
* Manages application amqp-queue.
*
* @author Maksym Kotliar <kotlyar.maksim@gmail.com>

This comment has been minimized.

@samdark

samdark Nov 29, 2017

Member

@since 2.0.2 (or which version is it going to be released it, @zhuravljov ?)

@samdark

samdark Nov 29, 2017

Member

@since 2.0.2 (or which version is it going to be released it, @zhuravljov ?)

Show outdated Hide outdated src/drivers/amqp_interop/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp_interop/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp_interop/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp_interop/Queue.php Outdated
Show outdated Hide outdated src/drivers/amqp_interop/Queue.php Outdated
Show outdated Hide outdated tests/drivers/amqp_interop/QueueTest.php Outdated
@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 29, 2017

Contributor

@samdark done

Contributor

makasim commented Nov 29, 2017

@samdark done

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 29, 2017

Contributor

Travis build fail is not related to my changes

Contributor

makasim commented Nov 29, 2017

Travis build fail is not related to my changes

@makasim makasim changed the title from Add AMQ interop based driver. to Add AMQP interop based driver. Nov 30, 2017

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 30, 2017

Contributor

@zhuravljov could you please give a hand with the error on Travis?

Contributor

makasim commented Nov 30, 2017

@zhuravljov could you please give a hand with the error on Travis?

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Nov 30, 2017

Contributor

@zhuravljov tests failed because of this commit d456b75.

While fixing it I realized that it is a good idea to keep setup broker logic and connection one separate.

If you mix them up you won't be able to do anything if setup broker fails. For example, the broker has the same queue but with a different argument for x-max-priorities and hence it complains. You won't able to do anything from the code, like deleting the queue and creating it from scratch.

Contributor

makasim commented Nov 30, 2017

@zhuravljov tests failed because of this commit d456b75.

While fixing it I realized that it is a good idea to keep setup broker logic and connection one separate.

If you mix them up you won't be able to do anything if setup broker fails. For example, the broker has the same queue but with a different argument for x-max-priorities and hence it complains. You won't able to do anything from the code, like deleting the queue and creating it from scratch.

@zhuravljov zhuravljov merged commit b4669cc into yiisoft:master Dec 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zhuravljov

This comment has been minimized.

Show comment
Hide comment
@zhuravljov

zhuravljov Dec 5, 2017

Member

It is merged. Thank you for big work!

Member

zhuravljov commented Dec 5, 2017

It is merged. Thank you for big work!

@zhuravljov zhuravljov referenced this pull request Dec 5, 2017

Closed

Queue Interop Support #104

@makasim makasim deleted the formapro-forks:amqp-interop branch Dec 5, 2017

@makasim

This comment has been minimized.

Show comment
Hide comment
@makasim

makasim Dec 5, 2017

Contributor

Party time! 🎉 🎉 🎉

Thank you guys for your patience and thoughtful reviews!

Contributor

makasim commented Dec 5, 2017

Party time! 🎉 🎉 🎉

Thank you guys for your patience and thoughtful reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment