Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridview FilterUrl does ignores # link in URL #12836

Closed
cebe opened this issue Oct 25, 2016 · 3 comments · Fixed by #12837
Closed

Gridview FilterUrl does ignores # link in URL #12836

cebe opened this issue Oct 25, 2016 · 3 comments · Fixed by #12837
Assignees
Labels
Milestone

Comments

@cebe
Copy link
Member

cebe commented Oct 25, 2016

What steps will reproduce the problem?

Create a Gridview Filter Url that should jump to the gridview inside of the page by appending the # id of the gridview:

    <?= GridView::widget([
        'id' => 'some-grid',
        'dataProvider' => $dataProvider,
        'filterModel' => $filterModel,
        'filterUrl' => Url::current(['#' => 'some-grid']),
        'columns' => [
// ...
        ],
    ]); ?>

What is the expected result?

After filtering the URL should end with #some-grid.

What do you get instead?

No # part of the URL.

Additional info

Q A
Yii version 2.0.10
@cebe cebe added the type:bug Bug label Oct 25, 2016
@cebe cebe self-assigned this Oct 25, 2016
@cebe cebe added this to the 2.0.11 milestone Oct 25, 2016
cebe added a commit that referenced this issue Oct 25, 2016
cebe added a commit that referenced this issue Oct 26, 2016
* Fixes Gridview JS to respect # in filterUrl

fixes #12836

* Update CHANGELOG.md
@arogachev
Copy link
Contributor

Fully fixed in #13230.

@cebe
Copy link
Member Author

cebe commented Dec 17, 2016

@arogachev thanks for taking care of this! Seems my JS skills are not up to date...

samdark pushed a commit that referenced this issue Dec 18, 2016
Additionally added tests for #10302 (#10284 (comment)), #10284 (#10217 (comment)), #11729
@arogachev
Copy link
Contributor

@cebe No problem. We all make mistakes sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants