Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine the list of predefined auth clients #1652

Closed
klimov-paul opened this issue Dec 27, 2013 · 9 comments
Closed

Determine the list of predefined auth clients #1652

klimov-paul opened this issue Dec 27, 2013 · 9 comments

Comments

@klimov-paul
Copy link
Member

@klimov-paul klimov-paul commented Dec 27, 2013

At recently added “authclient” extension (see #1620) there are 8 predefined clients:

  • Facebook
  • GitHub
  • GoogleOAuth
  • GoogleOpenId
  • LinkedIn
  • Twitter
  • YandexOAuth
  • YandexOpenId

We need to decide whether this list should be extended or shorten.
I suppose clients for “Facebook”, “Google”, “Twitter” and “LinkedIn” should be present without questioning.

I can add several more clients:

Waiting for opinions.

@samdark
Copy link
Member

@samdark samdark commented Dec 27, 2013

VKontakte should be included since it's the most popular auth method in ex-USSR. Existing list looks fine. No need to exclude anything.

@mgrechanik
Copy link
Contributor

@mgrechanik mgrechanik commented Dec 27, 2013

@klimov-paul

I can add several more clients:

Those clients you mentioned should better be included. At this popular drupal module you can check the most needed clients.

@Ragazzo
Copy link
Contributor

@Ragazzo Ragazzo commented Dec 27, 2013

I think the bigger the better, but only if you have time for that. Also it would be nice to have very detailed guide, because of some API are not so intuitive (like facebook and its requests with secret_id/etc) and takes sometimes several days to get into details, so good guide with some hints will be very useful.

@qiangxue
Copy link
Member

@qiangxue qiangxue commented Dec 27, 2013

Agree that the guide for developing new clients is very important. We don't need to cover all, but we should provide detailed instructions on how to extend to have more.

@Ragazzo
Copy link
Contributor

@Ragazzo Ragazzo commented Dec 27, 2013

Maybe even it would be great if there will be some demo based on all this API so user can see how it should work at demo example. But of course demo is great if you will have time for that.

@klimov-paul
Copy link
Member Author

@klimov-paul klimov-paul commented Jan 1, 2014

Docs updated at a4f8ce6

@DarkMukke
Copy link

@DarkMukke DarkMukke commented Jan 3, 2014

imo the Russian authClients are too localised. I think they should be in a separate extension. Would it not be better to have the codebase as small as possible ?

But I do agree with having a very detailed guide onto how to extend this. So people can make (preferably) an extentions for every additional authClient.

@cebe cebe added this to the 2.0 GA milestone Apr 6, 2014
@klimov-paul
Copy link
Member Author

@klimov-paul klimov-paul commented Apr 7, 2014

I have added Microsoft Live to the list of the clients.
This should be enough for now.
Any future request of new client addition should be considered separately.

@eaglemoor
Copy link

@eaglemoor eaglemoor commented Oct 8, 2014

Please add QQ (qq.com) oAuth provider. This is one of the biggest social networks in China

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.