New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine the list of predefined auth clients #1652

Closed
klimov-paul opened this Issue Dec 27, 2013 · 9 comments

Comments

Projects
None yet
8 participants
@klimov-paul
Member

klimov-paul commented Dec 27, 2013

At recently added “authclient” extension (see #1620) there are 8 predefined clients:

  • Facebook
  • GitHub
  • GoogleOAuth
  • GoogleOpenId
  • LinkedIn
  • Twitter
  • YandexOAuth
  • YandexOpenId

We need to decide whether this list should be extended or shorten.
I suppose clients for “Facebook”, “Google”, “Twitter” and “LinkedIn” should be present without questioning.

I can add several more clients:

Waiting for opinions.

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Dec 27, 2013

Member

VKontakte should be included since it's the most popular auth method in ex-USSR. Existing list looks fine. No need to exclude anything.

Member

samdark commented Dec 27, 2013

VKontakte should be included since it's the most popular auth method in ex-USSR. Existing list looks fine. No need to exclude anything.

@mgrechanik

This comment has been minimized.

Show comment
Hide comment
@mgrechanik

mgrechanik Dec 27, 2013

Contributor

@klimov-paul

I can add several more clients:

Those clients you mentioned should better be included. At this popular drupal module you can check the most needed clients.

Contributor

mgrechanik commented Dec 27, 2013

@klimov-paul

I can add several more clients:

Those clients you mentioned should better be included. At this popular drupal module you can check the most needed clients.

@Ragazzo

This comment has been minimized.

Show comment
Hide comment
@Ragazzo

Ragazzo Dec 27, 2013

Contributor

I think the bigger the better, but only if you have time for that. Also it would be nice to have very detailed guide, because of some API are not so intuitive (like facebook and its requests with secret_id/etc) and takes sometimes several days to get into details, so good guide with some hints will be very useful.

Contributor

Ragazzo commented Dec 27, 2013

I think the bigger the better, but only if you have time for that. Also it would be nice to have very detailed guide, because of some API are not so intuitive (like facebook and its requests with secret_id/etc) and takes sometimes several days to get into details, so good guide with some hints will be very useful.

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Dec 27, 2013

Member

Agree that the guide for developing new clients is very important. We don't need to cover all, but we should provide detailed instructions on how to extend to have more.

Member

qiangxue commented Dec 27, 2013

Agree that the guide for developing new clients is very important. We don't need to cover all, but we should provide detailed instructions on how to extend to have more.

@Ragazzo

This comment has been minimized.

Show comment
Hide comment
@Ragazzo

Ragazzo Dec 27, 2013

Contributor

Maybe even it would be great if there will be some demo based on all this API so user can see how it should work at demo example. But of course demo is great if you will have time for that.

Contributor

Ragazzo commented Dec 27, 2013

Maybe even it would be great if there will be some demo based on all this API so user can see how it should work at demo example. But of course demo is great if you will have time for that.

@klimov-paul

This comment has been minimized.

Show comment
Hide comment
@klimov-paul

klimov-paul Jan 1, 2014

Member

Docs updated at a4f8ce6

Member

klimov-paul commented Jan 1, 2014

Docs updated at a4f8ce6

@DarkMukke

This comment has been minimized.

Show comment
Hide comment
@DarkMukke

DarkMukke Jan 3, 2014

imo the Russian authClients are too localised. I think they should be in a separate extension. Would it not be better to have the codebase as small as possible ?

But I do agree with having a very detailed guide onto how to extend this. So people can make (preferably) an extentions for every additional authClient.

imo the Russian authClients are too localised. I think they should be in a separate extension. Would it not be better to have the codebase as small as possible ?

But I do agree with having a very detailed guide onto how to extend this. So people can make (preferably) an extentions for every additional authClient.

@cebe cebe added this to the 2.0 GA milestone Apr 6, 2014

@klimov-paul

This comment has been minimized.

Show comment
Hide comment
@klimov-paul

klimov-paul Apr 7, 2014

Member

I have added Microsoft Live to the list of the clients.
This should be enough for now.
Any future request of new client addition should be considered separately.

Member

klimov-paul commented Apr 7, 2014

I have added Microsoft Live to the list of the clients.
This should be enough for now.
Any future request of new client addition should be considered separately.

@eaglemoor

This comment has been minimized.

Show comment
Hide comment
@eaglemoor

eaglemoor Oct 8, 2014

Please add QQ (qq.com) oAuth provider. This is one of the biggest social networks in China

Please add QQ (qq.com) oAuth provider. This is one of the biggest social networks in China

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment