Create 2.0.16 release

[schmunk42]

Latest stable release is from March.
There have been quite some bugfixes.

2.0.16 was scheduled for 3rd quarter

• https://github.com/yiisoft/yii2/blob/master/ROADMAP.md
• https://github.com/yiisoft/yii2/milestone/25
  Issues should be moved to 2.0.17

I think it also makes sense to have a 2.x branch.

https://github.com/orgs/yiisoft/projects/14

[samdark]

There are some critical issues to be fixed. I've already moved some to next milestone but there are still plenty to check. If you have some time to burn, help is really appreciated.

[schmunk42]

Which ones are the critical ones ... "ready for adoption" + "bug"?

[samdark]

These are triaged ones. Not necessarily critical.

[schmunk42]

Can you post a link to a filtered view for triaged issues?

[samdark]

https://github.com/yiisoft/yii2/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22status%3Aready+for+adoption%22++milestone%3A2.0.16

[edit @schmunk42] fixed link

[schmunk42]

I think it would be good to adjust the release policy for 2.x slightly.
When looking at the changelog there are almost 80(!) bugs fixed for 2.0.16 - why keep them back? Issuing a patch release is perfectly fine.

The remaining open ones are looking rather hard and complicated to me (half of them are for PgSQL, MSSQL and Oracle), IMHO there's no need to wait until all of them are fixed to get a new release.

We're having a much greater flexibility regarding version numbers now.

[samdark]

Issuing a patch release is perfectly fine

Not till we're sure critical stuff is fixed. Non-critical issues should first be moved to next milestone.

[schmunk42]

I'd at least at a "critical" label then.

[samdark]

We haven't triaged all issues for the milestone so haven't applied labels yet.

[machour]

I went carefully over all issues with milestone 2.0.16 and postponed all non-critical issues to 2.0.17.

My definition of "non-critical" being: issue was already present for more than two 2.0.X releases, doesn't look like a 2.0.15 regression and isn't vital to 2.0.16.

We're down to 7 issues, including this one:

• can't write session on controller issue on 2.0.15.1 #16959: Related to sessions, awaiting feedback from reporter
• Yii2.0.15 reloads relation on key change but Yii2.0.13 didn't - BC break #16703: Important change introduced in 2.0.14. Should be documented.
• FindOne error when it using with an associative array or innerJoin #15931: Should have been fixed in 2.0.15.1, but there are still some problems.
• wrong condition in ActiveQuery::viaTable() #15876: Weird thing noticed by @cebe while reviewing [minor] SCA with Php Inspections (EA Ultimate) #15871, might be worth checking carefully before next release
• \yii\console\widgets\Table::widget problem with screenwidth #15552: Non critical but a PR is provided. Can be postponed.
• [yii\db\ActiveRelationTrait] ActiveRecord Relation Query Missing Some Data #15482: Old problem with a recent PR. Can be postponed.

[samdark]

Another thing: #16891. Regression.

[samdark]

Need to release ElasticSearch before doing core release. See #16891

[samdark]

yiisoft/yii2-elasticsearch#206

[machour]

I've been testing 2.0.16 on my biggest Yii 2.0.15 application for a week.

I just came across a breaking change in the Inflector::slug() method, which I think was introduced in #15204

2.0.15: Inflector::slug('0-100 Km/h', '_'); // 0_100_kmh
2.0.16: Inflector::slug('0-100 Km/h', '_'); // 0100_kmh

Not sure if this is the intended behavior, but I can foresee a LOT of migrations breaking & confused devs.

/cc @bizley

[samdark]

@machour no issues other than that?

[machour]

So far so good 🏅 aside from this issue (and I'm covering a load of Yii features)

[schmunk42]

Also related to 2.0.16 - #17049

[bizley]

@machour this looks like a mistake - I'll prepare fix.

[SilverFire]

It seems that we are ready to release?

[machour]

There's still #16780, but not sure it's a regression or if it can be postponed.

I think we need to test the release a bit more with basic/advanced & devs apps, seeing that we just fixed two "nasty" regressions today. Feb 1 seems like a good release date.

[samdark]

@SilverFire we need to review issues of basic/advanced apps. I'm starting to write announcement meanwhile.

[samdark]

Seems all the preparation things in this repo are completed. Closing. Will track things in a project: https://github.com/orgs/yiisoft/projects/14

[s1lver]

Seems all the preparation things in this repo are completed. Closing. Will track things in a project: https://github.com/orgs/yiisoft/projects/14

This link is not available

[samdark]

Fixed.