Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U+FEFF character on language file #2631

Closed
jneto81 opened this issue Mar 5, 2014 · 3 comments
Closed

U+FEFF character on language file #2631

jneto81 opened this issue Mar 5, 2014 · 3 comments
Assignees
@samdark
Milestone
2.0 Beta

Comments

@jneto81
Copy link
Contributor

jneto81 commented Mar 5, 2014

Hello, i found a problem with the PT language file
On the begin of yiisoft/yii2/messages/pt-PT/yii.php the U+FEFF character appears ( not visible with some editors) and because of that, before the

errorSummary($model); ?>

on the forms, i get the character inside the page that causes a empty line.

<input type="hidden" name="_csrf" value="U0hXbW8wQ0UCAWAiDGVyDwoqZB4MfyQKAzEZOD18LHIqIxY7OGp3Mg==">    <U+FEFF>
<div class="error-summary" style="display:none"><p>Por favor, corrija os seguintes erros:</p><ul></ul></div>
        <div class="form-group field-loginform-username required">

I try other translations from the file,

but so far, only the errorSummary generate the problem.

Removing the character from the file yiisoft/yii2/messages/pt-PT/yii.php solves the problem.
Not sure if other yii language files have the same problem.
@samdark
Copy link
Member

samdark commented Mar 5, 2014

Can you send a pull request fixing it?

@samdark samdark self-assigned this Mar 5, 2014
@jneto81
Copy link
Contributor Author

jneto81 commented Mar 5, 2014

I have to learn how to send a pull request first and work with git. I will try this week.
I will only remove the character from the file.

@samdark
Copy link
Member

samdark commented Mar 5, 2014

I can do it myself but trying yourself with git will help you a lot afterwards ;)

jneto81 added a commit to jneto81/yii2 that referenced this issue Mar 5, 2014
@jneto81
Removed U+FEFF character from pt-PT language file to fixe yiisoft#2631
310d77f
@jneto81 jneto81 mentioned this issue Mar 5, 2014
Merged
@cebe cebe added this to the 2.0 Beta milestone Mar 5, 2014
cebe added a commit that referenced this issue Mar 5, 2014
@cebe
Merge pull request #2640 from jneto81/2631-language-pt-pt-fix
bdce87b 
Removed U+FEFF character from pt-PT language file to fixe #2631
@cebe cebe closed this as completed Mar 5, 2014
cebe added a commit that referenced this issue Mar 6, 2014
@cebe
Merge branch 'master' into apidoc-refactoring
62378c3 
* master: (153 commits)
  rest doc.
  CS fix
  Add size attribute to Modal
  major features and documentation finished for REST API.
  rest WIP
  Removed U+FEFF character from pt-PT language file to fixe #2631
  Revert "Used ternary operator instead of "or" for constant definition"
  `User` here
  REST wip.
  Changelog
  reset access cache when user identity is set
  Keyboard shortcut for previous, next and refresh buttons
  reset batch query result when rewinding.
  fixed loading namespaceless controller classes.
  Fixes #1467: Added support for organizing controllers in subdirectories
  replace pjax with external resouce via composer
  fixed > 100 typos introduced by me :-)
  fixed condition for HHVM test
  fixed phpdoc
  updated phpdoc references of BaseAR to the interface
  ...

Conflicts:
	extensions/apidoc/templates/BaseRenderer.php
	extensions/apidoc/templates/html/views/constSummary.php
	extensions/apidoc/templates/html/views/propertyDetails.php
mrvanwagoner added a commit to mrvanwagoner/yii2 that referenced this issue Mar 21, 2014
@mrvanwagoner
Merge branch 'master' of https://github.com/yiisoft/yii2 into develop…
5442a4e 
…ment

# By jneto81
# Via Carsten Brandt (1) and jneto81 (1)
* 'master' of https://github.com/yiisoft/yii2:
  Removed U+FEFF character from pt-PT language file to fixe yiisoft#2631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
None yet
Projects
None yet
Milestone
2.0 Beta
Development

No branches or pull requests
3 participants
@samdark @cebe @jneto81