New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked Input Upgrade #3196

Closed
kartik-v opened this Issue Apr 21, 2014 · 15 comments

Comments

Projects
None yet
7 participants
@kartik-v
Contributor

kartik-v commented Apr 21, 2014

Upgrade masked input JQuery plugin to use this upgraded variant from Robin Herbots instead of Bush's version, as Robin's implementation allows more features including optional characters in the middle of the input. If needed I can submit a PR.

@cebe cebe added this to the 2.0 RC milestone Apr 21, 2014

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Apr 21, 2014

Member

Could you help with a PR? Thanks!

Member

qiangxue commented Apr 21, 2014

Could you help with a PR? Thanks!

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Apr 21, 2014

Contributor

Will work on a PR.

Wondering if this should be created as a separate yii2 extension - or retained in the widgets folder? Asking this because the newer plugin has more other options (and additional optional assets including extensions for date, time, phone etc.).

Contributor

kartik-v commented Apr 21, 2014

Will work on a PR.

Wondering if this should be created as a separate yii2 extension - or retained in the widgets folder? Asking this because the newer plugin has more other options (and additional optional assets including extensions for date, time, phone etc.).

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Apr 21, 2014

Member

hmm, please hold on a moment. I think we need more discussion about this.
@yiisoft/core-developers We are facing with this issue again: some core code depends on external js libs whose dependency is not managed by composer. Should we embrace bower?

Member

qiangxue commented Apr 21, 2014

hmm, please hold on a moment. I think we need more discussion about this.
@yiisoft/core-developers We are facing with this issue again: some core code depends on external js libs whose dependency is not managed by composer. Should we embrace bower?

@pmoust

This comment has been minimized.

Show comment
Hide comment
@pmoust

pmoust Apr 21, 2014

Contributor

@qiangxue I worked a bit on adding a solution on that, the core devs did not like adding Bowerphp so I have 've come up with using packages via Composer from VCS tree. I don't like it though I believe the Bower solution would be much better.
Check my closed PR on Bower, it is made that way that nodejs/bower is not needed, bowerphp is used instead.

Contributor

pmoust commented Apr 21, 2014

@qiangxue I worked a bit on adding a solution on that, the core devs did not like adding Bowerphp so I have 've come up with using packages via Composer from VCS tree. I don't like it though I believe the Bower solution would be much better.
Check my closed PR on Bower, it is made that way that nodejs/bower is not needed, bowerphp is used instead.

@pmoust

This comment has been minimized.

Show comment
Hide comment
@pmoust

pmoust Apr 21, 2014

Contributor

Link to the bowerphp PR #2965

Contributor

pmoust commented Apr 21, 2014

Link to the bowerphp PR #2965

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Apr 21, 2014

Contributor

+1 for bower support, if we can address dependency management with the composer packages.

Contributor

kartik-v commented Apr 21, 2014

+1 for bower support, if we can address dependency management with the composer packages.

@pmoust

This comment has been minimized.

Show comment
Hide comment
@pmoust

pmoust Apr 21, 2014

Contributor

@kartik-v you could pull #3209 and work from there having by adding jquery.inputmask in your bower.json. Let's see how it would look like. Just my two cents.

Contributor

pmoust commented Apr 21, 2014

@kartik-v you could pull #3209 and work from there having by adding jquery.inputmask in your bower.json. Let's see how it would look like. Just my two cents.

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Apr 22, 2014

Contributor

@pmoust thanks ... will wait for an update from @yiisoft/core-developers on how they want to include this - before I start.

Contributor

kartik-v commented Apr 22, 2014

@pmoust thanks ... will wait for an update from @yiisoft/core-developers on how they want to include this - before I start.

@yudilee

This comment has been minimized.

Show comment
Hide comment
@yudilee

yudilee Apr 22, 2014

I hope it could replace current masked input because current masked input have limited feature especially optional character in the middle of input

yudilee commented Apr 22, 2014

I hope it could replace current masked input because current masked input have limited feature especially optional character in the middle of input

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Apr 23, 2014

Contributor

@qiangxue / @yiisoft/core-developers I have the extension created and ready. Currently the plugin assets were used locally to create the extension. Let me know how I should submit a PR

  1. with extension classes included within yii/widgets and all assets included within yii/assets
  2. or as a separate yii2 extension.
  3. or wait for decision on embracing bower
Contributor

kartik-v commented Apr 23, 2014

@qiangxue / @yiisoft/core-developers I have the extension created and ready. Currently the plugin assets were used locally to create the extension. Let me know how I should submit a PR

  1. with extension classes included within yii/widgets and all assets included within yii/assets
  2. or as a separate yii2 extension.
  3. or wait for decision on embracing bower
@nkostadinov

This comment has been minimized.

Show comment
Hide comment
@nkostadinov

nkostadinov Apr 23, 2014

+1 for bower. It will complete the dependency management with composer. They are not conflicting.

nkostadinov commented Apr 23, 2014

+1 for bower. It will complete the dependency management with composer. They are not conflicting.

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Apr 23, 2014

Contributor

I submitted the PR #3225 with just ONE asset file jquery.inputmask.bundle.min.js replaced in the assets folder and exactly the same names for the MaskedInput and MaskedInputAsset classes. A demo of the upgraded plugin can be viewed HERE for review/test and merge.

If we decide on using bower or any other change to generating assets... will change the asset dependency accordingly.

Contributor

kartik-v commented Apr 23, 2014

I submitted the PR #3225 with just ONE asset file jquery.inputmask.bundle.min.js replaced in the assets folder and exactly the same names for the MaskedInput and MaskedInputAsset classes. A demo of the upgraded plugin can be viewed HERE for review/test and merge.

If we decide on using bower or any other change to generating assets... will change the asset dependency accordingly.

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Jun 3, 2014

Contributor

Let know if this is ready for adoption. A few examples on the new widget to get started

Contributor

kartik-v commented Jun 3, 2014

Let know if this is ready for adoption. A few examples on the new widget to get started

@samdark

This comment has been minimized.

Show comment
Hide comment
@samdark

samdark Jun 3, 2014

Member

@kartik-v is it a fork of original one we were using or totally new one? How stable it is? How supported i.e. is it updated often?

Member

samdark commented Jun 3, 2014

@kartik-v is it a fork of original one we were using or totally new one? How stable it is? How supported i.e. is it updated often?

@kartik-v

This comment has been minimized.

Show comment
Hide comment
@kartik-v

kartik-v Jun 3, 2014

Contributor

Its a new plugin. But its actually a fork and rewrite of Bush's version. It is updated periodically and till recently (as I see on github). I have not interacted with the plugin author personally though.

Contributor

kartik-v commented Jun 3, 2014

Its a new plugin. But its actually a fork and rewrite of Bush's version. It is updated periodically and till recently (as I see on github). I have not interacted with the plugin author personally though.

@cebe cebe closed this in 8331ff0 Jun 4, 2014

cebe added a commit that referenced this issue Jun 4, 2014

Merge pull request #3685 from kartik-v/3196-masked-input-revamped
Fix #3196: Masked input widget revamped to use new plugin

samdark added a commit that referenced this issue Jun 5, 2014

Merge pull request #3703 from kartik-v/patch-5
Masked input widget upgrade fixing #3196

tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014

tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014

Fix yiisoft#3196: Masked input widget revamped to use new plugin
Edited Asset Bundle PHP doc header information.

tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014

Merge pull request yiisoft#3685 from kartik-v/3196-masked-input-revamped
Fix yiisoft#3196: Masked input widget revamped to use new plugin

tvdavid pushed a commit to tvdavid/yii2 that referenced this issue Jul 24, 2014

Masked input widget upgrade fixing yiisoft#3196
Support contribution credits updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment