Implemented __sleep in yii\db\Connection to support serializing the c… #10149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection object without exceptions.
|
Can it be unserialized like that? |
|
Yes, I think so ^^. |
|
could you add the unserialization to the test? |
|
Yes, will do tomorrow. |
|
Done. |
|
Great. A line for the changelog file is needed. Then we'll merge it. |
|
I think this is mergable, it only fails on PHP7 but logs suggest that is PHP compilation error, not a source code error. |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnection object without exceptions.