Make validator getClientOptions public #13145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could you add that note to the UPGRADE guide please? |
This allows implementing custom client-side validation without extending every validator. Fixes yiisoft#11163
nkovacs
force-pushed
the
11163-validator-getclientoptions-public
branch
from
4d2c016
to
97ca9dc
Compare
|
Done. |
|
Since it's a backwards compatibilty break and isn't critical to have in 2.0.x, I'd merge it into 2.1.0 instead. @cebe ? |
|
I insist to merge this PR in 2.0.11 and here are the reasons:
|
|
There's also the option of calling it something else (though even then you're introducing a BC break, since if you call it foobar, and someone has a validator class with a protected function foobar, it'll break their code; the likelihood of this is lower, of course). |
samdark
approved these changes
Dec 7, 2016
dynasource
approved these changes
Dec 7, 2016
cebe
approved these changes
Dec 7, 2016
|
Need a changelog. Then ready to merge. |
|
no need for a changelog, #11163 does already have one. |
|
merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementing custom client-side validation
without extending every validator.
The backwards compatibility break is caused by the change in ImageValidator.
ImageValidator::getClientOptionswas protected since 2.0.0 (6dd2203#diff-504fd084646834cd27fce3dbdce26bbeR350), so if you extended the class and overrode the method with a protected method, the visibility change will cause a fatal error (because you can't make a public method protected in a subclass).Fixes #11163