Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkbox/radio for configurable enclosed option. #1397

Closed
wants to merge 2 commits into from

Conversation

@kartik-v
Copy link
Contributor

@kartik-v kartik-v commented Dec 2, 2013

The BaseHtml checkbox and radio implementation hard-codes a container to envelop the input when label is passed. For example: <div class="checkbox"> or <div class="radio">. This should be configurable. The current Pull Request allows the container enclosure to be optional by including an hasContainer option.This is set to true by default so current implementation is not affected. But it also allows this to be set to false for some scenarios. For example, the false option is very useful for generating inline checkbox lists or inline radio lists, where the enclosure is not required.

kartik-v added 2 commits Dec 2, 2013
The BaseHtml checkbox and radio implementation hard-codes a container to envelop the input when label is passed. For example: ```<div class="checkbox">``` or ```<div class="radio">```. This should be configurable. The current Pull Request allows the container enclosure to be optional by including an ```isEnclosed``` option.This is set to true by default. But it requires to be false for some scenarios. For example, the false option is very useful for generating inline checkbox lists or inline radio lists, where the enclosure is not required.
Updated ```isEnclosed``` to ```hasContainer``` - since there is an enclosed label somewhere (not to confuse). Also added unsetting of this variable in the ```options``` array after reading the value.
@qiangxue qiangxue closed this in 8362385 Dec 2, 2013
@kartik-v kartik-v deleted the kartik-v:patch-6 branch Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.