New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for tagName and encodeLabel parameters in ButtonDropdown #1601

Merged
merged 1 commit into from Dec 23, 2013

Conversation

Projects
None yet
2 participants
@omnilight
Contributor

omnilight commented Dec 23, 2013

No description provided.

@@ -89,10 +95,10 @@ protected function renderButton()
$splitButton = '';
}
return Button::widget([
'tagName' => $tag,
'tagName' => $this->tagName,

This comment has been minimized.

@qiangxue

qiangxue Dec 23, 2013

Member

You changed the behavior of the tagName which defaults to button regardless of the value of split.

@qiangxue

qiangxue Dec 23, 2013

Member

You changed the behavior of the tagName which defaults to button regardless of the value of split.

This comment has been minimized.

@qiangxue

qiangxue Dec 23, 2013

Member

Ignore my previous comment. It's fine.

@qiangxue

qiangxue Dec 23, 2013

Member

Ignore my previous comment. It's fine.

qiangxue added a commit that referenced this pull request Dec 23, 2013

Merge pull request #1601 from omnilight/improving-buttondropdown
Added support for tagName and encodeLabel parameters in ButtonDropdown

@qiangxue qiangxue merged commit 59f6b7f into yiisoft:master Dec 23, 2013

1 check passed

default The Travis CI build passed
Details
@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Dec 23, 2013

Member

Thanks!

Member

qiangxue commented Dec 23, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment