New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for #66: auth client implementation #1620

Merged
merged 41 commits into from Dec 25, 2013

Conversation

Projects
None yet
2 participants
@klimov-paul
Member

klimov-paul commented Dec 25, 2013

Fixes #66: OAuth, OAuth2 and OpenID consumers

Note: list of predefined auth clients can be adjusted.

Note: “Choice” widget markup should be advanced, but this task requires more skills and imagination then I have.

klimov-paul added some commits Dec 10, 2013

"yii\authclient\AuthAction" fixed.
"yii\authclient\ClientInterface" applied.
@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Dec 25, 2013

Member

wow! this is a major piece of work. I just browsed through the code. It looks great to me. Would you please also add a chapter to the definitive guide about this? Perhaps starting with an overall architecture of this extension? Thank you very much! I'm merging this PR. Will also create an subrepo and composer package for this.

Member

qiangxue commented Dec 25, 2013

wow! this is a major piece of work. I just browsed through the code. It looks great to me. Would you please also add a chapter to the definitive guide about this? Perhaps starting with an overall architecture of this extension? Thank you very much! I'm merging this PR. Will also create an subrepo and composer package for this.

@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Dec 25, 2013

Member

Could you update CHANGELOG file for both framework and the extension?

Member

qiangxue commented Dec 25, 2013

Could you update CHANGELOG file for both framework and the extension?

@klimov-paul

This comment has been minimized.

Show comment
Hide comment
@klimov-paul

klimov-paul Dec 25, 2013

Member

I'll see what I can do.

Member

klimov-paul commented Dec 25, 2013

I'll see what I can do.

qiangxue added a commit that referenced this pull request Dec 25, 2013

Merge pull request #1620 from klimov-paul/authclient
Proposal for #66: auth client implementation

@qiangxue qiangxue merged commit 5c57533 into yiisoft:master Dec 25, 2013

1 check passed

default The Travis CI build passed
Details
@qiangxue

This comment has been minimized.

Show comment
Hide comment
@qiangxue

qiangxue Dec 25, 2013

Member

merged.

Member

qiangxue commented Dec 25, 2013

merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment