Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist → exclude #18104

Merged
merged 2 commits into from Jun 14, 2020
Merged

blacklist → exclude #18104

merged 2 commits into from Jun 14, 2020

Conversation

brandonkelly
Copy link
Contributor

@brandonkelly brandonkelly commented Jun 14, 2020

In the same vein as #18102, we should avoid using “whitelist” and “blacklist” terms.

Yii doesn’t have any concepts or API docs that use those terms, so this PR only touches a couple things in the docs.

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️

docs/guide/rest-resources.md Outdated Show resolved Hide resolved
docs/guide/runtime-logging.md Outdated Show resolved Hide resolved
docs/guide/structure-models.md Outdated Show resolved Hide resolved
@samdark samdark added the type:docs label Jun 14, 2020
@brandonkelly brandonkelly changed the title blacklist → block blacklist → exclude Jun 14, 2020
@brandonkelly
Copy link
Contributor Author

@brandonkelly brandonkelly commented Jun 14, 2020

@samdark good call, just noticed that PHPUnit is going with “exclude” as well - https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-9.3.md#930---2020-08-07

@samdark samdark merged commit ba71065 into yiisoft:master Jun 14, 2020
11 checks passed
@brandonkelly brandonkelly deleted the block branch Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants