Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility PHP 8.3. #20074

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add compatibility PHP 8.3. #20074

merged 1 commit into from
Nov 23, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Nov 23, 2023

PR Summary

  • Added PHP 8.3 to project build workflows
    This PR introduces support for PHP 8.3 to the build workflows. This means that our project will now be automatically tested on PHP 8.3 in addition to previously supported PHP versions. This change covers different parts of our system including MSSQL, MySQL, PostgreSQL, and SQLite databases.

  • Modified value of variable in a test file
    A certain component of the system, covered by BaseDataProviderTest.php, has been subtly adjusted for improvements. This involves a change in the value of a variable ($rp). It usually means that we're tuning our testing processes to better reflect the software's behaviour. This ensures that future changes we make to the software are not likely to cause unrecognized problems.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fdb805) 48.02% compared to head (764f46c) 47.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20074      +/-   ##
==========================================
- Coverage   48.02%   47.56%   -0.46%     
==========================================
  Files         445      445              
  Lines       43889    43407     -482     
==========================================
- Hits        21077    20647     -430     
+ Misses      22812    22760      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit d43341a into yiisoft:master Nov 23, 2023
66 of 67 checks passed
@samdark
Copy link
Member

samdark commented Nov 23, 2023

Awesome. Thanks!

@samdark samdark added this to the 2.0.50 milestone Nov 23, 2023
@terabytesoftw terabytesoftw deleted the fix-php83 branch November 23, 2023 17:25
@smartycoder
Copy link

@samdark hi, when is 2.0.50 release to be expected. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants