Remove cache \yii\data\ActiveDataProvider::prepareTotalCount()

[lav45]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	✔️
Fixed issues	#20194 #20205

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.98%. Comparing base (fe5688d) to head (1ff1c65).

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #20206      +/-   ##
============================================
- Coverage     64.99%   64.98%   -0.01%     
+ Complexity    11392    11391       -1     
============================================
  Files           430      430              
  Lines         36925    36922       -3     
============================================
- Hits          23998    23993       -5     
- Misses        12927    12929       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[terabytesoftw]

You can test if this change resolves the yii2-elasticsearch issue.

[sleptor]

@lav45 @samdark Cache removal degraded performance.
Now, every page calls count query 4 times! I use kartik gridview

[mtangoo]

Can you test if it is the case with Plain Yii Gridview?

[sleptor]

Tested standard yii\grid\GridView (dev-master).
It makes 5 (five) identical count queries during webpage load. Checked from debug panel.

So, the cache definitely does not work, which affects performance notably.

[sleptor]

FYI
I described the issue and possible solution here
#20213