Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed usage of prop() to usage of attr() #8014

Merged
merged 1 commit into from Apr 8, 2015

Conversation

samdark
Copy link
Member

@samdark samdark commented Apr 7, 2015

It ensures that $form.prop('action') doesn't return DOM element in case there's hidden "action" input. It happened when submitting a form using a link with data-method defined. The rest of prop() usages are changed to match.

@samdark samdark changed the title Changed usage of prop() to usage of attr() which ensures that $form.prop... Changed usage of prop() to usage of attr() Apr 7, 2015
@samdark samdark added the type:bug Bug label Apr 7, 2015
@samdark samdark added this to the 2.0.4 milestone Apr 7, 2015
@samdark samdark force-pushed the yii-js-fix-form-action-property branch from b314718 to c7ca8bb Compare April 7, 2015 23:10
samdark added a commit that referenced this pull request Apr 7, 2015
…mitting a form using a link with "data-method" and containing "action" among "data-params"
…mitting a form using a link with "data-method" and containing "action" among "data-params"
@samdark samdark force-pushed the yii-js-fix-form-action-property branch from c7ca8bb to e224568 Compare April 8, 2015 00:19
samdark added a commit that referenced this pull request Apr 8, 2015
Changed usage of prop() to usage of attr()
@samdark samdark merged commit cc1b74a into master Apr 8, 2015
@samdark samdark deleted the yii-js-fix-form-action-property branch April 8, 2015 09:10
samdark added a commit that referenced this pull request Apr 9, 2015
…king with forms having input with names matching form properties. Related to #8014.
samdark pushed a commit that referenced this pull request Jan 25, 2017
- Bug #13300: Allow pjax with "data-pjax" with no value in `yii.js`.
- Bug #13307: Preventing of race conditions in script filter in `yii.js` works incorrectly.
- Bug #13310: Handle relative and absolute URLs coincidence in CSS filter in `yii.js`.
- Bug #13312: `skipOuterContainers` option was incorrectly passed to pjax in `handleAction` in `yii.js`.
- Partially fixes #13299.

Adds tests for #8014, #11921, #10974, #11494, #10358, #10097.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants