Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite interval #11

Merged
merged 3 commits into from Aug 5, 2019
Merged

Infinite interval #11

merged 3 commits into from Aug 5, 2019

Conversation

@rstub
Copy link
Contributor

@rstub rstub commented Jul 15, 2019

  • I wanted to have some sort of test in the vignette
  • Currently only integration with Numer::Func is handled. I haven't looked into Numer::RFunc
  • I tried to match the coding style. Please let me know if I missed some rules for parens/braces/...

fixes #10

@yixuan
Copy link
Owner

@yixuan yixuan commented Jul 25, 2019

Sorry for the long wait. I just didn't get some time to review and test the changes. ☹️
I believe it will do the job, so I hope I can make it in one week. ✌️

@yixuan yixuan merged commit feef2d3 into yixuan:master Aug 5, 2019
@yixuan
Copy link
Owner

@yixuan yixuan commented Aug 5, 2019

Thank you @rstub ! I have merged the PR. There is only one tiny issue: the example in the vignette uses a Beta distribution that is supported on (0, 1), making the infinite integral not so interesting. I'll fix this later.

@rstub
Copy link
Contributor Author

@rstub rstub commented Aug 7, 2019

Indeed, while technically correct the infinite interval does not make much sense here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.