Skip to content

/ showtext

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only showtext_auto() should record by default (showtext_begin() now can opt-in to it) #42

Merged
merged 2 commits into from Aug 10, 2020
Merged

Only showtext_auto() should record by default (showtext_begin() now can opt-in to it) #42

merged 2 commits into from Aug 10, 2020

Conversation

@cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Aug 7, 2020

Closes #41
@cpsievert
Only showtext_auto() should record by default (showtext_begin() now c…
ba0ab52 
…an opt-in to it)
@cpsievert
cpsievert reviewed Aug 7, 2020
View changes
R/showtext.R Outdated Show resolved Hide resolved
@cpsievert
Fix docs typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
884346a
@yixuan
Copy link
Owner

@yixuan yixuan commented Aug 7, 2020

Thank you @cpsievert! I'm doing some internal refactoring work to fix a few potential bugs. After I finish I'll return to this patch. It shouldn't take too long.
@yixuan
Copy link
Owner

@yixuan yixuan commented Aug 8, 2020

I've updated the code and it has conflicts with this patch. Don't worry about this. I'll fix it.
@cpsievert cpsievert mentioned this pull request Aug 8, 2020
Closed
@yixuan yixuan merged commit 1ebbeb7 into yixuan:master Aug 10, 2020
@cpsievert cpsievert deleted the cpsievert:recordGraphics branch Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

showtext_begin() now makes evaluate+knitr+rmarkdown think there is a plot to be replayed
2 participants
@cpsievert @yixuan
You can’t perform that action at this time.