Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a handle parameter to pass to curl::curl_download function #4

Merged
merged 1 commit into from Jul 27, 2017

Conversation

@Sdurier
Copy link
Contributor

@Sdurier Sdurier commented Jul 27, 2017

basically i add a handle parameter to function font.add.google and download_font_file, with default value curl::new_handle() which is the default value in curl::curl_download.

basically i add a handle  parameter to function font.add.google and download_font_file, with default value curl::new_handle() which is the default value in curl::curl_download.
@yixuan yixuan merged commit b729d5f into yixuan:master Jul 27, 2017
@yixuan
Copy link
Owner

@yixuan yixuan commented Jul 27, 2017

Thanks! Since I just updated sysfonts recently, it may take one or two weeks to submit the new version per CRAN's policy. I'll document your contribution in the NEWS file later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.