Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on specific levelup and leveldown versions #1

Closed
mitra42 opened this issue Oct 30, 2017 · 3 comments
Closed

Dependency on specific levelup and leveldown versions #1

mitra42 opened this issue Oct 30, 2017 · 3 comments

Comments

@mitra42
Copy link

mitra42 commented Oct 30, 2017

There appears to be a dependency in Y-leveldb on specific versions of levelup and leveldown that isn't captured by the dependency on level

levelup 2.0.0 wont work with Y-leveldb because it's constructor gets passed the path of the directory holding the database rather than an object which is what it requires now. .

I found that adding to my application's package.json
"levelup": "^1.0.0-4",
"leveldown": "^1.7.0-0",

It made sure Y-leveldb used the correct one, but I suspect that this dependency should be in Y instead. (or it should be fixed to work with levelup 2.0.0

@dmonad
Copy link
Member

dmonad commented Oct 30, 2017

Hi @mitra42 ,

Thanks for the info. I will eventually update to levelup 2.0.0. But I don't have much time to invest in y-leveldb at the moment.

level@2.0 just release a few days ago. Unfortunately they didn't release a changelog, So I need to make sure that y-leveldb still works with level@2.0.

@mitra42
Copy link
Author

mitra42 commented Oct 30, 2017

Understood - in the meantime you should probably place those two lines above in package.json. (It took me several hours to diagnose this particular problem, and figure out a set that worked since different versions of levelup have a dependency on different versions of leveldown !

@dmonad dmonad closed this as completed in 6dd8fc6 Oct 30, 2017
@dmonad
Copy link
Member

dmonad commented Oct 30, 2017

Done. Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants