New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elementary OS: menu items misplaced after refresh/change #55

Closed
megatux opened this Issue Jun 15, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@megatux
Copy link

megatux commented Jun 15, 2017

captura realizada el 2017-06-15 09 24 19

@megatux

This comment has been minimized.

Copy link
Author

megatux commented Jun 22, 2017

Also, if I click "Refresh" all inputs & outputs move to the bottom, too.

@yktoo

This comment has been minimized.

Copy link
Owner

yktoo commented Aug 28, 2017

Was already reported as #44 but no further info provided.

It looks like GTK+ bug and I wasn't able to reproduce it. What's your OS version?

Can you insert

print('Label: "%s"; index: "%d"' % (label, i))

before self.menu.insert(new_item, i) in indicator-sound-switcher and attach the output when it's run with the -vv command line switch, both before and after the refresh?

@megatux

This comment has been minimized.

Copy link
Author

megatux commented Aug 28, 2017

Elementary OS Loki with GTK+ 3.18.9. I did a refresh first, then a plug/unplug of headset. Attached imgs & debug output:

s1

s2
debug.txt

Let me know if you need something else. Thx!

@yktoo

This comment has been minimized.

Copy link
Owner

yktoo commented Aug 29, 2017

This is apparently Elementary (read Pantheon) specific as it's never been reported with Ubuntu. Will look at it as soon as I have time.

@yktoo yktoo changed the title New plugged devices are added to the bottom and not to the correct groups (inputs, outputs) Elementary OS: menu items misplaced after refresh/change Aug 29, 2017

@davidmaxwaterman

This comment has been minimized.

Copy link

davidmaxwaterman commented Feb 23, 2018

I think I see this on ubuntu 17:10 too:

screenshot from 2018-02-23 17-28-21

It looks fine when I start the app, but when I click refresh, all the outputs are moved under the inputs.
(version 2.1.1)

@davidmaxwaterman

This comment has been minimized.

Copy link

davidmaxwaterman commented Apr 11, 2018

Any thoughts on this? It's still broken many months later, and I'm not sure if it is a proven problem or not.

@yktoo

This comment has been minimized.

Copy link
Owner

yktoo commented Apr 11, 2018

It must be a bug in Gtk. If I look at the item order in memory, it's perfectly correct:

######### menu_insert_ordered_item(Outputs, ,     High Definition Audio Controller ‣ HDMI / DisplayPort, False)
#########+++ idx_from=3, idx_to=3
---------------- Item [2]/'Outputs'
---------------- Item [3]/''
------------ Added item 3/'    High Definition Audio Controller ‣ HDMI / DisplayPort'
######### menu_insert_ordered_item(Outputs, ,     High Definition Audio Controller ‣ HDMI / DisplayPort 2, False)
#########+++ idx_from=3, idx_to=4
---------------- Item [2]/'Outputs'
---------------- Item [3]/'    High Definition Audio Controller ‣ HDMI / DisplayPort'
---------------- Item [4]/''
------------ Added item 4/'    High Definition Audio Controller ‣ HDMI / DisplayPort 2'

Yet, the Outputs item is rendered below the corresponding output item:
screenshot from 2018-04-11 15-54-42

@yktoo

This comment has been minimized.

Copy link
Owner

yktoo commented Apr 11, 2018

A possible (lame) workaround might be to completely reload the entire menu.
Does this issue also occur when you plug/unplug devices?

yktoo added a commit that referenced this issue Nov 3, 2018

@yktoo

This comment has been minimized.

Copy link
Owner

yktoo commented Jan 13, 2019

Resolved in 2.2.0.

@yktoo yktoo closed this Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment